Page Index Toggle Pages: 1 ... 8 9 [10] 11 12 ... 15 ReplyAdd Poll Send Topic
Very Hot Topic (More than 25 Replies) Conversion (Read 45858 times)
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #135 - Sep 8th, 2017 at 1:39pm
Mark & QuoteQuote  
Deleting members has nothing to do with getting rid of bad data with the attachments log or bad data in message files.  (And the errors in Maintenance and Attachments deal with bad data in those other places.)

(And the problem in Display is also an attachment issue. Although why that one triggered for you and not for me is a mystery.)
For Display add
Code
Select All
        $mfn ||= q{}; 

just above the
Code
Select All
         chomp $mfn; 

on line 1005.

Edited:
The best I think we can do is add more checkers for bad data - Convert2x doesn't check anything in the *.txt files, it just copies the files over based on the info gathered in the Boards import without any changes and the Language conversion just converts ANSI to UTF-8.

The attachments log just gets renamed when copied.

I am guessing the *.txt file with the bad data doesn't trigger anything on my testbed due to the file name collisions in Boards. But I also didn't find anything in the 'raw' files I have. What the error in Maintenance is actually saying: the last line in *.txt doesn't have a number in the 3rd field. I can add a checker for that.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #136 - Sep 8th, 2017 at 2:41pm
Mark & QuoteQuote  
For the problem with Maintenance and Messages:
In Error.lng (all versions) add
Code
Select All
$error_txt{'bad data' } = q~File with bad data~; 


above the 1; at the bottom.

In Maintenance find
Code
Select All
            my $lastpostdate = sprintf '%010d', $lastinfo[3]; 



And add above it
Code
Select All
            if ($lastinfo[3] =~ /\D/xsm) {
                 fatal_error( 'bad data', "$datadir/$thread.txt", 1 );
             } 



This will cause the Rebuild Message Index to throw an error when it runs across a last line with bad data (specifically, when the 3rd field (first field is 0) has anything but numbers in it. It will tell you what file has the problem so you can fix it or remove that line (by hand).
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #137 - Sep 8th, 2017 at 3:11pm
Mark & QuoteQuote  
In Attachments.pm find
Code
Select All
    foreach (@attachments) {
         my $space = ( split /[|]/xsm, $_ )[5];
         $attachment_space += $space;
         $attachment_space = number_format($attachment_space);
     } 



replace with
Code
Select All
    foreach my $i (0 .. $#attachments) {
         my @check = split /[|]/xsm, $attachments[$i];
         if (scalar @check != 9) {
             fatal_error( 'bad data', "attachments.db bad line $i", 1 );
         }
         my $space = $check[5];
         if ($space =~ /\D/xsm || $space eq q{} ) {
             fatal_error( 'bad data', "attachments.db line $i", 1 );
         }
         $attachment_space += $space;
         $attachment_space = number_format($attachment_space);
     }

  



Like the new check in Maintenance, this one checks to make sure the field it's looking for has only numbers in it. If not, it throws an error telling you what line the problem is on in attachments.db (You already know what file you need to look in.)

I should probably add a check to make sure each line in attachments.db is exactly 9 fields long.  Undecided

Edited:
field number checker added above. Chances are the check for length will catch the $space error first.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #138 - Sep 8th, 2017 at 3:43pm
Mark & QuoteQuote  
And just so you don't think that the problem is with 2.7  - old YaBB ignored a lot of bad data when it crept in and since the bad data was ignored, it couldn't be fixed internally or send the admin warnings when things weren't right.

YaBB 2.7 catches all of those. So do the newer versions of Perl.

Also, when removing a member - only Memberlist and Memberinfo get edited when the member files get removed. That ex-member's data is still in all the posts they made and in attachment.db if they uploaded any attachments. Therefore, even though an error in a *.txt or in attachments.db might have a member's ID in it, the problem is actually something else entirely.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #139 - Sep 8th, 2017 at 6:32pm
Mark & QuoteQuote  
pyragony54 wrote on Sep 8th, 2017 at 5:06am:
Rebuild Message Index

Quote:
An Error Has Occurred. Argument "toskana102" isn't numeric in sprintf at /var/www/vhosts/yabbtest.de/cgi-bin/yabb2/Admin/Maintenance.pm line 171.


I have deleted the member completely, the error appears anyway.



The error I could fix, it was only a bad contribution from member toskana102.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #140 - Sep 8th, 2017 at 7:15pm
Mark & QuoteQuote  
Dandello wrote on Sep 8th, 2017 at 3:43pm:
the problem is actually something else entirely.
                   


Since you are probably very right. The structure of the attachments also does not work so.
The debugger always shows the last attachment as defective.

Quote:
File with bad data attachments.db bad line 68358


If I remove this line, it simply counts down.
Have it tried with well 20 entries now. After the conversion, about 30000 attachments are missing.

Quote:

Ein Fehler ist aufgetreten! Use of uninitialized value $atfile in hash element at Sources/Display.pm line 1027, <_GEN_9> line 68359.

As I see it, this error only appears in topics where there are attachments.

This also seems to be related to the appendices. He always shows one more.

I think the attachments are not converted correctly.

Edited:
I'll start another try. I will rebuild everything in the main forum (attachments, members and topics) and then times everything in the test forum play and re-covert. Let's see what's going to happen.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #141 - Sep 8th, 2017 at 8:32pm
Mark & QuoteQuote  
Okay, in Display.pm find
Code
Select All
                    $attach_count{$atfile} = $atcount; 


and add above it
Code
Select All
                    $atcount ||= 0; 



This will force the download count to be 0 if there's no number. I think if you look at the raw data in attachments.db, you may find most of the lines in your file end with | instead of | and a number.

You may have to open your attachments.db in a spreadsheet  - replace all the | with a tab (\t) so you'll be able to manipulate the data (or zip up the old txt file and the new .db file and sent them to me so I can run a comparison in a spreadsheet - but there is definitely something off with those files and it seems to be getting worse.

Also, if your Convert2x created a Variables/datacheck.txt file - zip that up and send it along.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #142 - Sep 9th, 2017 at 1:10am
Mark & QuoteQuote  
pyragony54 wrote on Sep 8th, 2017 at 7:15pm:
Since you are probably very right. The structure of the attachments also does not work so.
The debugger always shows the last attachment as defective.

Quote:
File with bad data attachments.db bad line 68358


It's dumb, but try adding a linebreak after the last item. It's remotely possible that when the file gets read into the array, it's not reading that last line as finished.

And if not all the attachments are getting transferred - you may have to zip up that folder and upzip it in the new install. (I'll be testing on the BoardMod Mirror next week.)
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #143 - Sep 9th, 2017 at 8:45am
Mark & QuoteQuote  
So I'm also a little idiot. If I had first in the mainforum the maintenance mode go through and then only the necessary files from the main forum to the test forum, everything would have looked better and many errors would not show up.

Two errors still appear, but my opinion is not the software.
I am now looking at what I still find there with the help of your debugger.
What I noticed, however, in some rubrics was not sorted by "last post", although I have set it so. Can you look in the test forum.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #144 - Sep 9th, 2017 at 9:38am
Mark & QuoteQuote  
Okay

Clean Users Online Log

Quote:
An Error Has Occurred. Use of uninitialized value $boardv in hash element at Sources/BoardIndex.pm line 2307.


This error appears only once and you do not get to the board index. If I reload the page, the board index appears as if nothing had happened.



First I'm not on the board rules (only visible for registered members). Error message. After installing the debugger it worked.



Some posts can not be opened and this error message appears.
What can be the cause of this error? I do not think it is a software error.

Quote:
An Error Has Occurred. Use of uninitialized value $boardname in concatenation (.) or string at Sources/Load.pm line 442.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #145 - Sep 9th, 2017 at 1:57pm
Mark & QuoteQuote  
pyragony54 wrote on Sep 9th, 2017 at 9:38am:
Quote:
An Error Has Occurred. Use of uninitialized value $boardv in hash element at Sources/BoardIndex.pm line 2307.


This error appears only once and you do not get to the board index. If I reload the page, the board index appears as if nothing had happened.


$boardv can legitimately be blank - but I don't why your system is throwing a hissy and mine doesn't. The error clears up because the Variables/user.log gets rewritten everytime someone enters the forum or looks at something.

In BoardIndex find
Code
Select All
        foreach (@logentries) {
             ( $name, $date1, $last_ip, $last_host, undef, $boardv, undef ) =
               split /[|]/xsm, $_, 7;  


Add after
Code
Select All
$boardv ||= q{}; 



Quote:
Quote:
An Error Has Occurred. Use of uninitialized value $boardname in concatenation (.) or string at Sources/Load.pm line 442.


This is going to be due to bad data in forum.master. There's a board in there that doesn't have data in the first field. (look for '$board{'admin'}' as that shouldn't be there in 2.7 But I also just noticed that data didn't transfer for admin/admin_fix into forum.control  Embarrassed )

as a fix try:
In Load.pm find
Code
Select All
                    my $boardname = ${$board{$i}}[0];
                     $mybrds .= qq~$boardname<br />~;
                     return 1; 



replace with
Code
Select All
                    if (${$board{$i}}[0]) {
                         my $boardname = ${$board{$i}}[0];
                         $mybrds .= qq~$boardname<br />~;
                         return 1;
                     } 



All of these, so far, have nothing to do with Mods. For whatever reason, your install is more sensitive to uninitialized values than mine - maybe it's a Perl difference or a Perl on Windows difference. But it isn't a bad thing. As I said before: old YaBB ignored a lot of things that should have thrown errors. 2.7 throws the errors.

But once I see where the error message is pointing to I can see exactly what's happening and why.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #146 - Sep 9th, 2017 at 2:41pm
Mark & QuoteQuote  
Give me bug reports but don't do any new conversions until I have the new Convert2x ready. (Next week sometime.) I found some odd omissions and have to test the multi-language support.

Also, SpellChecker hasn't worked right in quite some time so I think now's the time to remove it.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #147 - Sep 9th, 2017 at 3:02pm
Mark & QuoteQuote  
I also find it class, the YaBB 2.7 does not ignore the error.
My server is running Debian, not Windows. I'm not stupid.
Windows Server and you have already lost.
The two error messages are gone.
The only downside, some forums are not sorted by last post.
Look here:

http://yabbtest.de/cgi-bin/yabb2/YaBB.pl?board=LKV

You have there also admin rights, so you can see it.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: Conversion
Reply #148 - Sep 9th, 2017 at 3:11pm
Mark & QuoteQuote  
Dandello wrote on Sep 9th, 2017 at 2:41pm:
Give me bug reports but don't do any new conversions until I have the new Convert2x ready. (Next week sometime.) I found some odd omissions and have to test the multi-language support.

Also, SpellChecker hasn't worked right in quite some time so I think now's the time to remove it.



I do this way.
Spelling check away, no problem. I really do not need it with my IQ.
But I am already listening to members.

The German files are almost ready except the help files. I think I can deliver it by Wednesday.
  

if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Conversion
Reply #149 - Sep 9th, 2017 at 4:05pm
Mark & QuoteQuote  
pyragony54 wrote on Sep 9th, 2017 at 3:02pm:
The only downside, some forums are not sorted by last post.


That's weird since the same Board sorts just fine in my test install.  Huh (in WAMPP)
Edited:
I'm able to reproduce the problem on one install.

  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1 ... 8 9 [10] 11 12 ... 15
ReplyAdd Poll Send Topic
Bookmarks: del.icio.us Digg Facebook Google LinkedIn reddit Twitter Yahoo
Conversion

Please type the characters exactly as they appear in the image,
without the first 2 and last 2 characters.
The characters must be typed in the same order,
and they are case-sensitive.
Open Preview Preview

You can resize the textbox by dragging the right or bottom border.
Off Topic Comment Insert Spoiler
Insert Hyperlink Insert FTP Link Insert Image Insert E-mail Insert Media Insert Table Insert Table Row Insert Table Column Insert Horizontal Rule Insert Teletype Insert Code Insert Quote Edited Superscript Subscript Insert List /me - my name Insert Marquee Insert Timestamp No Parse
Bold Italicized Underline Insert Strikethrough Highlight
                       
Change Text Color
Insert Preformatted Text Left Align Centered Right Align
resize_wb
resize_hb







Max 5000 characters. Remaining characters:
Text size: %
More Smilies
View All Smilies
Collapse additional features Collapse/Expand additional features Smiley Wink Cheesy Grin Angry Sad Shocked Cool Huh Roll Eyes Tongue Embarrassed Lips Sealed Undecided Kiss Cry