Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Register.template Sep 27th, 2014 at 6:58pm Mark & QuoteQuote Missing closing/opening tags... Code Index: cgi-bin/yabb2/Templates/default/Register.template =================================================================== --- cgi-bin/yabb2/Templates/default/Register.template (revision 1583) +++ cgi-bin/yabb2/Templates/default/Register.template (working copy) @@ -361,8 +361,10 @@ <table class="tabtitle"> <tr> <td style="padding-left:1%; height:25px"><img src="$imagesdir/register.gif" alt="$prereg_txt{'1a'}" title="$prereg_txt{'1a'}" /><b>$prereg_txt{'1a'}</b></td> + </tr> </table> <table class="pad_4px cs_thin"> + <tr> <td class="windowbg">$prereg_txt{'13'}</td> </tr> </table> @@ -374,8 +376,10 @@ <td style="padding-left:1%; height:25px" colspan="2"> <img src="$imagesdir/register.gif" alt="$prereg_txt{'1a'}" title="$prereg_txt{'1a'}" /> <b>$prereg_txt{'1a'}</b> </td> - </table> - <table class="pad_4px cs_thin" style="width:650px"> + </tr> + </table> + <table class="pad_4px cs_thin" style="width:650px"> + <tr> <td class="windowbg center" colspan="2"> <br />$prereg_txt{'5'}~; GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Register.template Reply #1 - Sep 27th, 2014 at 7:46pm Mark & QuoteQuote Um - those aren't only ones - I found a span with 2 closes and a label without one. I'm sure there are more. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Register.template Reply #2 - Sep 27th, 2014 at 8:33pm Mark & QuoteQuote Dandello wrote on Sep 27th, 2014 at 7:46pm:Um - those aren't only ones - I found a span with 2 closes and a label without one. I'm sure there are more. Yeah... You know what is the silliest thing I have found so far... eh... That must be.... a table consisting of just a single content cell... lol... those should definitely be replaced with a simple div-block. Just like in (at least) one of the template files there is a table that is split in three pieces... for a weird reason... only because the "second piece" is empty in most scenarios... and that really makes it really hard to reformat the "table" as the "empty" piece (read: table row/rows) is created completely outside the file only when needed. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Register.template Reply #3 - Sep 27th, 2014 at 8:43pm Mark & QuoteQuote Part of the 'problem' is that when YaBB was first designed, the only way to position things on the page was by using tables. And then people started putting divs inside the tables... : We'll get there - I promised myself to get rid of as many tables as possible during to move to HTML5. I'm hoping for Christmas. (This Christmas.) Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Weird code Reply #4 - Sep 28th, 2014 at 7:18am Mark & QuoteQuote In Admin/ManageTemplates.pm there is at least two places where code is no-op... first there is line "... = q{};" and right below the contents of same variable is replaced... The variables I found so far were $admincss and $forumcss. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Register.template Reply #5 - Sep 28th, 2014 at 2:31pm Mark & QuoteQuote ManageTemplates has some serious problems properly rendering pages in the iframe too. Since the same errors show up in both MSIE and FireFox I know it's an html code processing issue that's probably been there a long long time. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Register.template Reply #6 - Sep 28th, 2014 at 3:49pm Mark & QuoteQuote Dandello wrote on Sep 28th, 2014 at 2:31pm:ManageTemplates has some serious problems properly rendering pages in the iframe too. Since the same errors show up in both MSIE and FireFox I know it's an html code processing issue that's probably been there a long long time. I haven't really tried playing with the templates editing as last time I did hit server error when I tried and that was before I figured out ModSecurity doesn't like YaBB... Getting ModSecurity fixed takes about 2 weeks per rule, so I'm not really keen in retrying... GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Register.template Reply #7 - Sep 28th, 2014 at 4:18pm Mark & QuoteQuote I'm gaining on the beggar - lots of semi-hard coded stuff to be fixed. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Pages: 1
Register.template (Read 2925 times)
HTML 5
HTML 5