YaBB Development & Mods

(UTC)

Change Template: Choose Language:

Topic Summary - Displaying 8 post(s). Click here to show all

Posted by: Dandello
Posted on: Sep 28^th, 2014 at 4:18pm

I'm gaining on the beggar - lots of semi-hard coded stuff to be fixed.

Posted by: Monni
Posted on: Sep 28^th, 2014 at 3:49pm

Dandello wrote on Sep 28^th, 2014 at 2:31pm:

ManageTemplates has some serious problems properly rendering pages in the iframe too. Since the same errors show up in both MSIE and FireFox I know it's an html code processing issue that's probably been there a long long time. Smiley

I haven't really tried playing with the templates editing as last time I did hit server error when I tried and that was before I figured out ModSecurity doesn't like YaBB... Getting ModSecurity fixed takes about 2 weeks per rule, so I'm not really keen in retrying...

Posted by: Dandello
Posted on: Sep 28^th, 2014 at 2:31pm

Posted by: Monni
Posted on: Sep 28^th, 2014 at 7:18am

In Admin/ManageTemplates.pm there is at least two places where code is no-op...

first there is line "... = q{};" and right below the contents of same variable is replaced... The variables I found so far were $admincss and $forumcss.

Posted by: Dandello
Posted on: Sep 27^th, 2014 at 8:43pm

Part of the 'problem' is that when YaBB was first designed, the only way to position things on the page was by using tables. And then people started putting divs inside the tables... :

We'll get there - I promised myself to get rid of as many tables as possible during to move to HTML5. I'm hoping for Christmas. (This Christmas.)

Posted by: Monni
Posted on: Sep 27^th, 2014 at 8:33pm

Dandello wrote on Sep 27^th, 2014 at 7:46pm:

Um - those aren't only ones - I found a span with 2 closes and a label without one. Huh

I'm sure there are more.

Yeah... You know what is the silliest thing I have found so far... eh... That must be.... a table consisting of just a single content cell... lol... those should definitely be replaced with a simple div-block.

Just like in (at least) one of the template files there is a table that is split in three pieces... for a weird reason... only because the "second piece" is empty in most scenarios... and that really makes it really hard to reformat the "table" as the "empty" piece (read: table row/rows) is created completely outside the file only when needed.

Posted by: Dandello
Posted on: Sep 27^th, 2014 at 7:46pm

Um - those aren't only ones - I found a span with 2 closes and a label without one. Huh

I'm sure there are more.

Posted by: Monni
Posted on: Sep 27^th, 2014 at 6:58pm

Missing closing/opening tags...

Code

 Index: cgi-bin/yabb2/Templates/default/Register.template
 ===================================================================
 --- cgi-bin/yabb2/Templates/default/Register.template	(revision 1583)
 +++ cgi-bin/yabb2/Templates/default/Register.template	(working copy)
 @@ -361,8 +361,10 @@
                      <table class="tabtitle">
                          <tr>
                              <td style="padding-left:1%; height:25px"><img src="$imagesdir/register.gif" alt="$prereg_txt{'1a'}" title="$prereg_txt{'1a'}" /><b>$prereg_txt{'1a'}</b></td>
 +                        </tr>
                      </table>
                      <table class="pad_4px cs_thin">
 +                        <tr>
                              <td class="windowbg">$prereg_txt{'13'}</td>
                          </tr>
                      </table>
 @@ -374,8 +376,10 @@
                  <td style="padding-left:1%; height:25px" colspan="2">
                      <img src="$imagesdir/register.gif" alt="$prereg_txt{'1a'}" title="$prereg_txt{'1a'}" /> <b>$prereg_txt{'1a'}</b>
                  </td>
 -            </table>
 -            <table class="pad_4px cs_thin" style="width:650px">
 +            </tr>
 +        </table>
 +        <table class="pad_4px cs_thin" style="width:650px">
 +            <tr>
                  <td class="windowbg center" colspan="2">
                      <br />$prereg_txt{'5'}~;

Question:

Options:	Text	Color	Split Pie
Option 1:
Option 2:
Option 3:
Option 4:
Option 5:
Option 6:
Option 7:
Option 8:
Poll Comment:	Max 500 characters. Remaining characters:

Automatic End in:	days and minutes. Leave it blank if you don't want to set it now.
Enable Guest Voting:	Check this if you want guests to be able to vote in this poll.
Hide results:	Check this if you do not want the results of this poll shown until voting has been closed.
Multiple Choice	Check this if you want to allow users to vote for more than one option.
Time limit for deleting vote:	Time in minutes users are allowed to delete their vote (0 to disable delete).
Use legends for Pie Chart	Check this to use legends instead of labels next to each pie slice.
Pie Chart Radius:	Must be a value between 100 and 200 (default 100)

Name:
E-mail:
Your Verification Code is:	Please type the characters exactly as they appear in the image, without the first 2 and last 2 characters. The characters must be typed in the same order, and they are case-sensitive.
Verification Code:
Preview