Revising my previous patch...

 --- C:/Users/Mika/AppData/Local/Temp/PostBox.pm-revBASE.svn001.tmp.pm	Fri Aug 22 16:41:00 2014
 +++ C:/build/yabb/trunk/cgi-bin/yabb2/Sources/PostBox.pm	Mon Aug 25 00:41:31 2014
 @@ -20,6 +20,8 @@
  $postboxpmver = 'YaBB 2.6.0 $Revision: 1545 $';
  if ( defined $actions && $action eq 'detailedversion' ) { return 1; }
  get_micon();
 +$ubbcbak = 'ubbc2.png';
 +
  #InstantMessage.pm and Post.pl use the same code for the posting box - why have two copies? #

  sub postbox {
 @@ -912,7 +914,7 @@
          $boxlist .= qq~<span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src='$imagesdir/UBBC/$img' onclick='$click;' $hand alt='$alt' title='$alt' /></span>\n~;
          $w++
      }
 -    $boxlist_w = $w * 23;
 +    $boxlist_w = $w * 24;
      return ($boxlist, $boxlist_w);
  }

 @@ -933,7 +935,7 @@
      else {
          $mod_w = 1 + int $w/2;
      }
 -    $boxlist_w = $mod_w * 23;
 +    $boxlist_w = $mod_w * 24;
      return ($boxlist, $boxlist_w);
  }

  

XTC wrote on Aug 24^th, 2014 at 8:05pm:


Thanks, updated the patch in previous post...

Dandello wrote on Aug 24^th, 2014 at 11:58pm:


I tried to widen it and I had to add 15 pixels before it looked normal. The difference is that in other forums with custom templates there is actually 1 pixel padding between the UBBC buttons... You can adjust .ubbcbutton's margin-left and margin-right (default is -2px for both) to realign the two lines.

XTC wrote on Aug 25^th, 2014 at 10:03am:


It is obvious one fix doesn't work for all templates... I edited only PostBox.pm to align the css buttons. I haven't figured out yet what is the difference that adds the 1 pixel padding to custom templates on Chrome here, but not default template.
I also tested with IE, but it seems it looks even worse as the padding isn't even constant and varies between 0 and 1 pixels... When I did set "float: left" and cleared left and right margins for CSS buttons, the gap disappeared when using Chrome, but as the button spacing was still hardcoded to 24 in sources, the two rows were not same width yet.

I couldn't find where the padding/margin on the span/images was coming from either - that's why the ubbcbutton css has the

margin: 0 -2px 

Dandello wrote on Aug 25^th, 2014 at 6:06pm:


I pretty much rewrote the PostBox.pm last night to cleanup things... I strongly think we should hardcode this filename instead of spreading the variable all around the files... There is some other fixes I need to diff, but currently my tree is pretty much based on assumptions what will become 2.6.2 or beyond, and not 2.6.1... I need to clean it up before I can make a usable diff.

This is the version I have now... Looks good with both Chrome and IE with constant 1 pixel padding...

 Index: cgi-bin/yabb2/Sources/PostBox.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/PostBox.pm	(revision 1550)
 +++ cgi-bin/yabb2/Sources/PostBox.pm	(working copy)
 @@ -66,21 +66,20 @@
      ( $boxlist1, $boxlist1_w )   = ubbc_boxlist(%boxlist1);
      ( $textdecor, $textdecor_w ) = ubbc_boxlist(%textdecor);
      ( $txtalgn, $txtalgn_w )     = ubbc_boxlist(%txtalgn);
 -    $fntcolor_w = 91;
 +    $fntcolor_w = 93;
      $font_w = $boxlist1_w - ( $textdecor_w + $txtalgn_w + $fntcolor_w );
      $ubbc_box_w = $boxlist1_w + $mods_w;
 -    $px = 'px';
 -    $box = qq~            <div style="float:left; width:$ubbc_box_w$px">
 -            <div style="float:right; width:$mods_w$px">
 +    $box = qq~            <div style="float:left; width:${ubbc_box_w}px">
 +            <div style="float:right; width:${mods_w}px">
              $mods
              </div>
 -            <div style="float:left; width:$boxlist1_w$px">
 +            <div style="float:left; width:${boxlist1_w}px">
              $boxlist1
              <br /></div>
 -            <div style="float:left; width:$textdecor_w$px">
 +            <div style="float:left; width:${textdecor_w}px">
              $textdecor
              </div>
 -            <div style="float:left; text-align:center; width:$font_w$px">
 +            <div style="float:left; text-align:center; width:${font_w}px">
              <select name="fontface" id="fontface" onchange="if(this.options[this.selectedIndex].value) fontfce(this.options[this.selectedIndex].value);">
                  <option value="Verdana">Verdana</option>
                  <option value="">-\\-\\-\\-\\-\\-\\-\\-\\-</option>
 @@ -132,7 +131,7 @@
                  if(thistask == "templ") previewColor(newcolor);
              }
              </script>
 -            <div style="float:left; height:22px; width:$fntcolor_w$px">
 +            <div style="float:left; height:22px; width:${fntcolor_w}px">
                  <div class="palettebox">
                      <span class="deftpal" style="background-color: #000000;" onclick="ConvShowcolor('#000000')">&nbsp;</span>
                      <span class="deftpal" style="background-color: #333333;" onclick="ConvShowcolor('#333333')">&nbsp;</span>
 @@ -147,11 +146,11 @@
                      <span id="defaultpal5" class="deftpal" style="background-color: $pallist[4];" onclick="ConvShowcolor(this.style.backgroundColor)">&nbsp;</span>
                      <span id="defaultpal6" class="deftpal" style="background-color: $pallist[5];" onclick="ConvShowcolor(this.style.backgroundColor)">&nbsp;</span>
                   </div>
 -                 <div style="float:right; height:22px; padding-left: 1px; width: 23px;">
 +                 <div style="float:right; height:22px; padding-left: 1px; padding-right: 1px; width: 23px;">
                       <span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src="$imagesdir/UBBC/palette1.png" class="cursor" onclick="window.open('$scripturl?action=palette;task=post', '', 'height=308,width=302,menubar=no,toolbar=no,scrollbars=no')" alt="" /></span>
                    </div>
              </div>
 -            <div style="float:left; width:$txtalgn_w$px">
 +            <div style="float:left; width:${txtalgn_w}px">
              $txtalgn
              </div>
          </div>
 @@ -912,7 +911,7 @@
          $boxlist .= qq~<span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src='$imagesdir/UBBC/$img' onclick='$click;' $hand alt='$alt' title='$alt' /></span>\n~;
          $w++
      }
 -    $boxlist_w = $w * 23;
 +    $boxlist_w = $w * 24;
      return ($boxlist, $boxlist_w);
  }

 @@ -933,7 +932,7 @@
      else {
          $mod_w = 1 + int $w/2;
      }
 -    $boxlist_w = $mod_w * 23;
 +    $boxlist_w = $mod_w * 24;
      return ($boxlist, $boxlist_w);
  }

 Index: public_html/yabbfiles/Templates/Forum/default.css
 ===================================================================
 --- public_html/yabbfiles/Templates/Forum/default.css	(revision 1550)
 +++ public_html/yabbfiles/Templates/Forum/default.css	(working copy)
 @@ -1293,7 +1293,7 @@
      height: 22px;
      width: 23px;
      border: 0;
 -    margin: 0 -2px;
 +    margin: 0 1px 1px 0;
      background-position: top right;
      background-repeat: no-repeat;
      text-decoration: none;
 @@ -1300,6 +1300,7 @@
      font-size: 18px;
      vertical-align: top;
      display: inline-block;
 +    float: left;
  }

  .tt { font-family: Courier, monospace; }
  

Dandello wrote on Aug 25^th, 2014 at 8:16pm:


I don't have Firefox on this machine anymore... It was a lost cause with constant glitches and need to reinstall... I can debug the current template I have on my laptop though...

Edited:


It shouldn't do that unless the "float: left;" line is missing or on wrong line of the file...

the whole block should read:

 .ubbcbutton {
     height: 22px;
     width: 23px;
     border: 0;
     margin: 0 1px 1px 0;
     background-position: top right;
     background-repeat: no-repeat;
     text-decoration: none;
     font-size: 18px;
     vertical-align: top;
     display: inline-block;
     float: left;
 }
  

Dandello wrote on Aug 25^th, 2014 at 9:21pm:


You almost scared me...

Found some other spots where the old css was interferring with the new. Also added a 'use today' option for the Event Calendar.

Should we fix those bad '||' bits first?  I've spotted some where I can't even figure out what they're suppose to do.

Like line 2782 in Post.pm

            $mname ||= $musername || $post_txt{'470'}; 

 

as near as I can tell it should be

            $mname = $musername || $post_txt{'470'}; 

as $musername should be either 'Guest' or a userID and this is just an error catcher in case it's empty.

if ( ! defined $mname || $mname eq q{} ) { $mname = defined $musername ? $musername : $post_txt{'470'} ; }
   

?

Both $mname and $musername come out of a split message string so could actually have a value of empty string - in which case there's more bad things going on with that message string than just not having $mname defined. 

if ( ! defined $mname || $mname eq q{} ) { $mname = (defined $musername && $musername ne q{} ) ? $musername : $post_txt{'470'} ; }
   

I was rewriting it as you posted. 

According to http://www.perlmonks.org/?node_id=653404 ||= should evaluate as false undefined, empty string and 0 values. Where we may still have some glitches are those places where '0' and empty are a valid values.

Monni wrote on Aug 26^th, 2014 at 3:55pm:

Exactly.

I'll look at adding a 'isempty' sub to make things neater. (When we start on 2.6.2 I think we'll need to establish Perl 5.010 or even a bit higher as the Perl requirement so we can use newer and better shortcuts. ModuleChecker now has a Perl Version readout so telling people they need a newer version shouldn't be that hard.)

One thing I know for sure is that whenever the check involves a setting read from user vars file or forum settings file, we need to use isempty... because plain undefined check can cause Perl to crash.

Monni wrote on Aug 27^th, 2014 at 10:11am:


This is one of the things I'm testing

sub isempty {
     my ($x, $y) = @_;
     if ( defined $x && $x ne q{} ) {
         $y = $x;
     }
     return $y;
 } 

Not using it on things like vars or boards that are loaded in Load (Those are both fed into hashes so those things need to be checked in Load and I haven't gotten there yet. )

Where I'm using the new sub is in the spots where the result should be 'something', including a '0', but not a 'nothing'. In Settings we have some spots where 'nothing' is allowed but should be a 0 and some spots where it could be a 0 but 'nothing' should be something else. (Like the image sizes.)

I went though all the '||='s, checked on what the possible good results were and decided if it should be a '||=' or a ' = isempty'.

I need to do more testing but should have it in the SVN later today.

(Also converted the '||' related to the fopen function to 'or' - it's lower precidence and it what's usually used for system call errors anyway. Also makes for fewer '||' to check.  :)

$y isn't a local, $y is the alternate value.

$myval = isempty($x, $y); 

if $x isn't empty, it should return $x (even if $x == 0), otherwise it should return $y. (Kind of halfway between $x //= $y; and $x ||= $y;)

Where I'm currently using it is in places where there's a hard-coded good value for $y or in spots where if $y is a bad value, there's a subsequent catcher or it goes to a string like 'ex-member'.

There's one spot I can think of offhand where $z might be useful. (And I can't find it at the moment.    - it had to do with sorting.)

Monni wrote on Aug 27^th, 2014 at 3:44pm:


The only time that should be an issue is if someone is using ancient vars files and didn't process them through one of the Convert utilites on upgrading - in that case they've got more problems than just missing user display names.  :  (YaBB Forum is still has messed up vars files because it didn't get run through Convert - EVER! on any upgrade! EVER!)

I'll track down the multiple Form, Info, whatever calls.

Ah hah - off to check the converters after I get more coffee.

That one actually works as designed - registered users should either see UTC or their timezone choice. Guests will see UTC or the Admin's forum choice. In either case the default is UTC. (Now, we could add a reminder for members to update their tz choice...  )

There was actually a lot of discussion on this when we decided to trash the old 'never worked right' TimeZone system.  A '-8' tz correction doesn't mean a lot when it's wrong a big part of the time and if DateTime::TimeZone is working, it REALLY doesn't mean anything. If we do decide to put back an ability to set an hour offset for users, it will only work if DateTime::TimeZone is not working.

Dandello wrote on Aug 27^th, 2014 at 6:56pm:


In most local area forums, there really is only one timezone that most of the users expect to be in use... As long as admin is wise enough to set the default timezone, there is really no use for user timezone. For the less than 1% of the registered users who want to use different timezone, the user_tz option is useful.

Dandello wrote on Aug 27^th, 2014 at 7:09pm:


Looks ok, but I need to logout to test that with my test account

Dandello wrote on Aug 27^th, 2014 at 7:21pm:


I could test the change quickly in one of my clients forum, because I'm still logged in to its cPanel... I just don't leave the change in permanently until I have talked with the forum admin

Two standard smileys in @SmilieURL of Settings.pm and all group stars stopped working, because the extension changed from .gif to .png. Not to mention the Admin Center gave me lots of 503 errors trying to edit forum settings. I had to fix settings file manually because %templateset didn't save correctly.

Dandello wrote on Aug 27^th, 2014 at 7:49pm:


The forum didn't have custom stars... They were the default ones back when the forum was still using old version of YaBB.

Same goes for the smileys... two smileys (exclamation and question) were renamed so didn't work with default template, but did work with custom template used on the forum.

Dandello wrote on Aug 27^th, 2014 at 8:02pm:


That's actually what I did back then Took me a while to check that no other graphics were MIA...