Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #15 - Aug 25th, 2014 at 8:38pm Mark & QuoteQuote Dandello wrote on Aug 25th, 2014 at 8:16pm:And this is what I'm seeing in Firefox on my testbed: Edited: Now, there may be some minor differences in the default.css file between what's on the test bed and what's in the SVN and I'll double check those in a bit. I don't have Firefox on this machine anymore... It was a lost cause with constant glitches and need to reinstall... I can debug the current template I have on my laptop though... Edited: I just checked the rendering on my laptop and Firefox, and it looks the same as with Chrome and IE. On my client's forum, the alignment is PERFECT. And on this forum it is OK except shifted by two pixels, which is expected. It shouldn't do that unless the "float: left;" line is missing or on wrong line of the file... the whole block should read: Code .ubbcbutton { height: 22px; width: 23px; border: 0; margin: 0 1px 1px 0; background-position: top right; background-repeat: no-repeat; text-decoration: none; font-size: 18px; vertical-align: top; display: inline-block; float: left; } GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #16 - Aug 25th, 2014 at 9:21pm Mark & QuoteQuote The float:left was missing - looks good on my testbed. Will upload here in a bit. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #17 - Aug 25th, 2014 at 9:22pm Mark & QuoteQuote Dandello wrote on Aug 25th, 2014 at 9:21pm:The float:left was missing - looks good on my testbed. Will upload here in a bit. You almost scared me... GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #18 - Aug 25th, 2014 at 10:38pm Mark & QuoteQuote Not having a good day - Took an out-of-town guest out to dinner last night and woke up trying to figure out how to call in sick... (I didn't have anything alcoholic so that isn't it.) Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #19 - Aug 26th, 2014 at 3:44am Mark & QuoteQuote Found some other spots where the old css was interferring with the new. Also added a 'use today' option for the Event Calendar. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #20 - Aug 26th, 2014 at 7:50am Mark & QuoteQuote lol... getting closer to point where code freeze for 2.6.1 would make sense... Stop fixing bugs and hiccups so we still have enough left to fix for 2.6.2 : GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #21 - Aug 26th, 2014 at 3:05pm Mark & QuoteQuote Should we fix those bad '||' bits first? I've spotted some where I can't even figure out what they're suppose to do. Like line 2782 in Post.pm Code (Perl) $mname ||= $musername || $post_txt{'470'}; as near as I can tell it should be Code (Perl) $mname = $musername || $post_txt{'470'}; as $musername should be either 'Guest' or a userID and this is just an error catcher in case it's empty. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #22 - Aug 26th, 2014 at 3:13pm Mark & QuoteQuote Dandello wrote on Aug 26th, 2014 at 3:05pm:Should we fix those bad '||' bits first? I've spotted some where I can't even figure out what they're suppose to do. Like line 2782 in Post.pm Code (Perl) $mname ||= $musername || $post_txt{'470'}; as near as I can tell it should be Code (Perl) $mname = $musername || $post_txt{'470'}; as $musername should be either 'Guest' or a userID and this is just an error catcher in case it's empty. ||= is supposed to be //= which means set if not defined... So something like: Code $mname = defined $musername ? $musername : $post_txt{'470'} unless defined $mname; This is pretty much harakiri code as this doesn't work if $musername or $mname is defined but empty string. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #23 - Aug 26th, 2014 at 3:24pm Mark & QuoteQuote Code (Perl)if ( ! defined $mname || $mname eq q{} ) { $mname = defined $musername ? $musername : $post_txt{'470'} ; } ? Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #24 - Aug 26th, 2014 at 3:28pm Mark & QuoteQuote Dandello wrote on Aug 26th, 2014 at 3:24pm:Code (Perl)if ( ! defined $mname || $mname eq q{} ) { $mname = defined $musername ? $musername : $post_txt{'470'} ; } ? almost... it doesn't check if $musername is empty string yet... But is that even possible? GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #25 - Aug 26th, 2014 at 3:31pm Mark & QuoteQuote Both $mname and $musername come out of a split message string so could actually have a value of empty string - in which case there's more bad things going on with that message string than just not having $mname defined. Code (Perl)if ( ! defined $mname || $mname eq q{} ) { $mname = (defined $musername && $musername ne q{} ) ? $musername : $post_txt{'470'} ; } Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #26 - Aug 26th, 2014 at 3:33pm Mark & QuoteQuote Dandello wrote on Aug 26th, 2014 at 3:31pm:Both $mname and $musername come out of a split message string so could actually have a value of empty string - in which case there's more bad things going on with that message string than just not having $mname defined. Code (Perl)if ( ! defined $mname || $mname eq q{} ) { $mname = (defined $musername || $musername = q{} ) ? $musername : $post_txt{'470'} ; } The bad code usually looks better than the good code... But it's better to make the code safe than fix it twice... GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #27 - Aug 26th, 2014 at 3:35pm Mark & QuoteQuote I was rewriting it as you posted. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #28 - Aug 26th, 2014 at 3:39pm Mark & QuoteQuote Dandello wrote on Aug 26th, 2014 at 3:35pm:I was rewriting it as you posted. It could look a little nicer if we could move the "not defined or empty" test as a sub/function isempty() or something... only parameter to it would be the variable to test and it would return false only if the variable is defined and at least 1 character long. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #29 - Aug 26th, 2014 at 3:42pm Mark & QuoteQuote According to http://www.perlmonks.org/?node_id=653404 ||= should evaluate as false undefined, empty string and 0 values. Where we may still have some glitches are those places where '0' and empty are a valid values. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Pages: 
Re: Looking toward 2.6.1 (Read 30021 times)
HTML 5
HTML 5