Revising my previous patch...

 --- C:/Users/Mika/AppData/Local/Temp/PostBox.pm-revBASE.svn001.tmp.pm	Fri Aug 22 16:41:00 2014
 +++ C:/build/yabb/trunk/cgi-bin/yabb2/Sources/PostBox.pm	Mon Aug 25 00:41:31 2014
 @@ -20,6 +20,8 @@
  $postboxpmver = 'YaBB 2.6.0 $Revision: 1545 $';
  if ( defined $actions && $action eq 'detailedversion' ) { return 1; }
  get_micon();
 +$ubbcbak = 'ubbc2.png';
 +
  #InstantMessage.pm and Post.pl use the same code for the posting box - why have two copies? #

  sub postbox {
 @@ -912,7 +914,7 @@
          $boxlist .= qq~<span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src='$imagesdir/UBBC/$img' onclick='$click;' $hand alt='$alt' title='$alt' /></span>\n~;
          $w++
      }
 -    $boxlist_w = $w * 23;
 +    $boxlist_w = $w * 24;
      return ($boxlist, $boxlist_w);
  }

 @@ -933,7 +935,7 @@
      else {
          $mod_w = 1 + int $w/2;
      }
 -    $boxlist_w = $mod_w * 23;
 +    $boxlist_w = $mod_w * 24;
      return ($boxlist, $boxlist_w);
  }

  

XTC wrote on Aug 24^th, 2014 at 8:05pm:


Thanks, updated the patch in previous post...

Dandello wrote on Aug 24^th, 2014 at 11:58pm:


I tried to widen it and I had to add 15 pixels before it looked normal. The difference is that in other forums with custom templates there is actually 1 pixel padding between the UBBC buttons... You can adjust .ubbcbutton's margin-left and margin-right (default is -2px for both) to realign the two lines.

XTC wrote on Aug 25^th, 2014 at 10:03am:


It is obvious one fix doesn't work for all templates... I edited only PostBox.pm to align the css buttons. I haven't figured out yet what is the difference that adds the 1 pixel padding to custom templates on Chrome here, but not default template.
I also tested with IE, but it seems it looks even worse as the padding isn't even constant and varies between 0 and 1 pixels... When I did set "float: left" and cleared left and right margins for CSS buttons, the gap disappeared when using Chrome, but as the button spacing was still hardcoded to 24 in sources, the two rows were not same width yet.

I couldn't find where the padding/margin on the span/images was coming from either - that's why the ubbcbutton css has the

margin: 0 -2px 

Dandello wrote on Aug 25^th, 2014 at 6:06pm:


I pretty much rewrote the PostBox.pm last night to cleanup things... I strongly think we should hardcode this filename instead of spreading the variable all around the files... There is some other fixes I need to diff, but currently my tree is pretty much based on assumptions what will become 2.6.2 or beyond, and not 2.6.1... I need to clean it up before I can make a usable diff.

This is the version I have now... Looks good with both Chrome and IE with constant 1 pixel padding...

 Index: cgi-bin/yabb2/Sources/PostBox.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/PostBox.pm	(revision 1550)
 +++ cgi-bin/yabb2/Sources/PostBox.pm	(working copy)
 @@ -66,21 +66,20 @@
      ( $boxlist1, $boxlist1_w )   = ubbc_boxlist(%boxlist1);
      ( $textdecor, $textdecor_w ) = ubbc_boxlist(%textdecor);
      ( $txtalgn, $txtalgn_w )     = ubbc_boxlist(%txtalgn);
 -    $fntcolor_w = 91;
 +    $fntcolor_w = 93;
      $font_w = $boxlist1_w - ( $textdecor_w + $txtalgn_w + $fntcolor_w );
      $ubbc_box_w = $boxlist1_w + $mods_w;
 -    $px = 'px';
 -    $box = qq~            <div style="float:left; width:$ubbc_box_w$px">
 -            <div style="float:right; width:$mods_w$px">
 +    $box = qq~            <div style="float:left; width:${ubbc_box_w}px">
 +            <div style="float:right; width:${mods_w}px">
              $mods
              </div>
 -            <div style="float:left; width:$boxlist1_w$px">
 +            <div style="float:left; width:${boxlist1_w}px">
              $boxlist1
              <br /></div>
 -            <div style="float:left; width:$textdecor_w$px">
 +            <div style="float:left; width:${textdecor_w}px">
              $textdecor
              </div>
 -            <div style="float:left; text-align:center; width:$font_w$px">
 +            <div style="float:left; text-align:center; width:${font_w}px">
              <select name="fontface" id="fontface" onchange="if(this.options[this.selectedIndex].value) fontfce(this.options[this.selectedIndex].value);">
                  <option value="Verdana">Verdana</option>
                  <option value="">-\\-\\-\\-\\-\\-\\-\\-\\-</option>
 @@ -132,7 +131,7 @@
                  if(thistask == "templ") previewColor(newcolor);
              }
              </script>
 -            <div style="float:left; height:22px; width:$fntcolor_w$px">
 +            <div style="float:left; height:22px; width:${fntcolor_w}px">
                  <div class="palettebox">
                      <span class="deftpal" style="background-color: #000000;" onclick="ConvShowcolor('#000000')">&nbsp;</span>
                      <span class="deftpal" style="background-color: #333333;" onclick="ConvShowcolor('#333333')">&nbsp;</span>
 @@ -147,11 +146,11 @@
                      <span id="defaultpal5" class="deftpal" style="background-color: $pallist[4];" onclick="ConvShowcolor(this.style.backgroundColor)">&nbsp;</span>
                      <span id="defaultpal6" class="deftpal" style="background-color: $pallist[5];" onclick="ConvShowcolor(this.style.backgroundColor)">&nbsp;</span>
                   </div>
 -                 <div style="float:right; height:22px; padding-left: 1px; width: 23px;">
 +                 <div style="float:right; height:22px; padding-left: 1px; padding-right: 1px; width: 23px;">
                       <span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src="$imagesdir/UBBC/palette1.png" class="cursor" onclick="window.open('$scripturl?action=palette;task=post', '', 'height=308,width=302,menubar=no,toolbar=no,scrollbars=no')" alt="" /></span>
                    </div>
              </div>
 -            <div style="float:left; width:$txtalgn_w$px">
 +            <div style="float:left; width:${txtalgn_w}px">
              $txtalgn
              </div>
          </div>
 @@ -912,7 +911,7 @@
          $boxlist .= qq~<span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src='$imagesdir/UBBC/$img' onclick='$click;' $hand alt='$alt' title='$alt' /></span>\n~;
          $w++
      }
 -    $boxlist_w = $w * 23;
 +    $boxlist_w = $w * 24;
      return ($boxlist, $boxlist_w);
  }

 @@ -933,7 +932,7 @@
      else {
          $mod_w = 1 + int $w/2;
      }
 -    $boxlist_w = $mod_w * 23;
 +    $boxlist_w = $mod_w * 24;
      return ($boxlist, $boxlist_w);
  }

 Index: public_html/yabbfiles/Templates/Forum/default.css
 ===================================================================
 --- public_html/yabbfiles/Templates/Forum/default.css	(revision 1550)
 +++ public_html/yabbfiles/Templates/Forum/default.css	(working copy)
 @@ -1293,7 +1293,7 @@
      height: 22px;
      width: 23px;
      border: 0;
 -    margin: 0 -2px;
 +    margin: 0 1px 1px 0;
      background-position: top right;
      background-repeat: no-repeat;
      text-decoration: none;
 @@ -1300,6 +1300,7 @@
      font-size: 18px;
      vertical-align: top;
      display: inline-block;
 +    float: left;
  }

  .tt { font-family: Courier, monospace; }