(UTC)
Change Template: 
Choose Language:
YaBB Development & Mods › Bug Zone › YaBB 2.7 Issues › move/split/splice Bottom
‹ Previous Topic | Next Topic ›
Page Index Toggle Pages: 1 ReplyAdd Poll Send Topic
Normal Topic move/split/splice (Read 2938 times)
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
move/split/splice
Oct 1st, 2017 at 6:14am
Mark & QuoteQuote  
Many error messages

Quote:
An Error Has Occurred. Use of uninitialized value $currentboard in concatenation (.) or string at Sources/Display.pm line 280.


Quote:
An Error Has Occurred. Use of uninitialized value in substitution iterator at Sources/Mailer.pm line 193.


Quote:
Untrapped Error :
Cannot open boards.txt at /var/www/vhosts/yabbtest.de/cgi-bin/yabb2/Sources/MoveSplitSplice.pm line 195.


It is not possible to combine two posts.
There was another error message, which I can not understand now,
she had clicked away too quickly and just did not appear.

I can not find a file boards.txt anywhere.


Edited:
Here is the missing error message

Quote:
An Error Has Occurred. Argument "" isn't numeric in numeric eq (==) at /var/www/vhosts/yabbtest.de/cgi-bin/yabb2/Sources/MoveSplitSplice.pm line 266.
« Last Edit: Oct 1st, 2017 at 7:19am by pyragony54 »  
if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2234
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: move/split/splice
Reply #1 - Oct 1st, 2017 at 1:41pm
Mark & QuoteQuote  
MoveSplitSplice has always been a right royal pain in the behind.
The error in Mailer actually comes from Post.pm. The error in Display (I think) comes from the move data not being properly written because of previous problems.

So I'm working on it.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2234
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: move/split/splice
Reply #2 - Oct 1st, 2017 at 2:04pm
Mark & QuoteQuote  
Okay in Post.pm find:
Code (Perl)
Select All
                    if ($accept_permafull) {
                         $topiclink =
 qq~$perm_domain/$symlink/$permdate/$currentboard/$thisthread~;
                     }
                     sendmail(
                         $curmail,
                         "$notifysubjects{$curlang}{'136'}: $thissubject",
                         template_email(
                             $notifystrings{$curlang}{'boardnotificationemail'},
                             {
                                 'subject'  => $thissubject,
                                 'num'      => $topiclink,
                                 'start'    => $page,
                                 'tauthor'  => $thisauthor,
                                 'tmessage' => $thismessage
                             }
                         ),
                         q{},
                         $notifycharset{$curlang}{'emailcharset'}
                     );
                     $mailsent{$curuser} = 1;
                 }

Replace with:
Code (Perl)
Select All
                    if ($accept_permafull) {
                         $topiclink =
 qq~$perm_domain/$symlink/$permdate/$currentboard/$thisthread~;
                     }
                     if ( $thissubject && $topiclink && $page && $thisauthor && $thismessage ) {
                     sendmail(
                         $curmail,
                         "$notifysubjects{$curlang}{'136'}: $thissubject",
                         template_email(
                             $notifystrings{$curlang}{'boardnotificationemail'},
                             {
                                 'subject'  => $thissubject,
                                 'num'      => $topiclink,
                                 'start'    => $page,
                                 'tauthor'  => $thisauthor,
                                 'tmessage' => $thismessage
                             }
                         ),
                         q{},
                         $notifycharset{$curlang}{'emailcharset'}
                     );
                     $mailsent{$curuser} = 1;
                 }
                 }


This will stop the Mailer from running if any email info is missing.

In MoveSplitSplice.pm find
Code (Perl)
Select All
        if (   $FORM{'position'}
             && $newthread == $FORM{'old_position_thread'} )
         {

and replace with
Code (Perl)
Select All
        if (   $FORM{'position'}
             && $FORM{'old_position_thread'} && $newthread == $FORM{'old_position_thread'} )
         {

  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: move/split/splice
Reply #3 - Oct 3rd, 2017 at 1:10am
Mark & QuoteQuote  
Not yet in the SVN? Okay, I have not tested it yet. Will do it the same time.
  
if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: move/split/splice
Reply #4 - Oct 3rd, 2017 at 1:30am
Mark & QuoteQuote  
Upsss, I think now something went wrong.

Code
Select All
                    $mailsent{$curuser} = 1;


Looks quite different in the SVN.

Code
Select All
            undef %{ $uid . $curuser };




Quote:
Untrapped Error :
Global symbol "$page" requires explicit package name at Sources/Post.pm line 2473. Global symbol "$page" requires explicit package name at Sources/Post.pm line 2482. Global symbol "%mailsent" requires explicit package name at Sources/Post.pm line 2490. Missing right curly or square bracket at Sources/Post.pm line 3331, at end of line syntax error at Sources/Post.pm line 3331, at EOF Compilation failed in require at Sources/Display.pm line 2126.
  
if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2234
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: move/split/splice
Reply #5 - Oct 3rd, 2017 at 2:16am
Mark & QuoteQuote  
Yeah, something went wrong. The SVN version looks different due to indenting. I know Post.pm build 1910 is good.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: move/split/splice
Reply #6 - Oct 3rd, 2017 at 6:45am
Mark & QuoteQuote  
Looks like everything will work.
No error message at the moment.

However, the field (Select which topic to move the selected Posts to.) Is much too long and does not appear to be limited. See Screener. You can not see anything.
  
if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2234
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: move/split/splice
Reply #7 - Oct 3rd, 2017 at 1:29pm
Mark & QuoteQuote  
This really was on my to-do list. Thanks for reminding me.  Embarrassed

Edited:
Okay, in MoveSplitSplice.pm find all 3 instances of
Code (Perl)
Select All
 my $convertstr = $message;
and all 3 instances of
Code (Perl)
Select All
 my $convertcut = 50;

and make the 'my' into 'our' .
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box pyragony54
Language
***
Offline


I Love YaBB!

Posts: 852
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Mood: Dead
Zodiac sign: Scorpio
Re: move/split/splice
Reply #8 - Oct 4th, 2017 at 4:40am
Mark & QuoteQuote  
Quote:
An Error Has Occurred. Argument "" isn't numeric in addition (+) at /var/www/vhosts/yabbtest.de/cgi-bin/yabb2/Sources/MoveSplitSplice.pm line 685.
« Last Edit: Oct 4th, 2017 at 8:54am by pyragony54 »  
if (idea == 'none') {use (manuals) && (Google | | search)}
if ($ answer == 0) {post (question)}
Back to top
 
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2234
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: move/split/splice
Reply #9 - Oct 4th, 2017 at 1:35pm
Mark & QuoteQuote  
Smiley - trying to reproduce the error.

Edited:
What where you trying to do when you got that? I've tested move post to different thread, move posts to new thread with new subject, move posts to new thread without new subject.


Edited:
Okay - I'm guessing here. In MoveSplitSplice find
Code (Perl)
Select All
    else {
         ${$newthreadid}{'views'} +=
           int( ${$curthreadid}{'views'} / @curthread * @postnum );
     }

and replace with
Code (Perl)
Select All
    else {
         ${$newthreadid}{'views'} ||= 0;
         ${$newthreadid}{'views'} +=
           int( ${$curthreadid}{'views'} / @curthread * @postnum );
     }

I'm guessing that the problem was on the left of the '+' sign.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
ReplyAdd Poll Send Topic
‹ Previous Topic | Next Topic ›
Bookmarks: del.icio.us Digg Facebook Google LinkedIn reddit Twitter Yahoo
move/split/splice

Please type the characters exactly as they appear in the image,
without the first 2 and last 2 characters.
The characters must be typed in the same order,
and they are case-sensitive.
Open Preview Preview

You can resize the textbox by dragging the right or bottom border.
Off Topic Comment Insert Spoiler
Insert Hyperlink Insert FTP Link Insert Image Insert E-mail Insert Media Insert Table Insert Table Row Insert Table Column Insert Horizontal Rule Insert Teletype Insert Code Insert Quote Edited Superscript Subscript Insert List /me - my name Insert Marquee Insert Timestamp No Parse
Bold Italicized Underline Insert Strikethrough Highlight
                       
Change Text Color
Insert Preformatted Text Left Align Centered Right Align
resize_wb
resize_hb







Max 5000 characters. Remaining characters:
Text size: %
More Smilies
View All Smilies
Collapse additional features Collapse/Expand additional features Smiley Wink Cheesy Grin Angry Sad Shocked Cool Huh Roll Eyes Tongue Embarrassed Lips Sealed Undecided Kiss Cry
 

YaBB Development & Mods » Powered by YaBB 2.7.00!
YaBB Forum Software © 2000-2024. All Rights Reserved.

Valid RSS HTML 5 Valid CSS Powered by Perl Source Forge

Page completed in 1.1641 seconds.