YaBB Development & Mods

Topic Summary - Displaying 7 post(s). Click here to show all

Posted by: Monni
Posted on: Oct 1^st, 2014 at 7:02pm

Dandello wrote on Oct 1^st, 2014 at 6:55pm:

On the list for 2.6.2 - replace all single cell tables with divs, replace all spacer-only cells with padding or margin css. Clean up multiple nested tables with divs.

We'll also be looking at using html5 tags like nav, header, footer, article.

THEN, we'll look at mobile/mini-screen versions which may require some interesting detection and template calling.

I'm slowly trying to clean up the custom template I made for one of my clients... It is blend of three templates, old blue_1, old custom template used on that forum and the new default template in 2.6.0/2.6.1... I will post some of the changes I make as they might be useful in default template for 2.6.2.

Posted by: Dandello
Posted on: Oct 1^st, 2014 at 6:55pm

Posted by: Monni
Posted on: Oct 1^st, 2014 at 5:59pm

Replace tables with empty cells with divs... Only for 2.6.2, because this will break some mods...

Code

 Index: 2.6/cgi-bin/yabb2/Templates/default/default.html
 ===================================================================
 --- 2.6/cgi-bin/yabb2/Templates/default/default.html	(revision 1587)
 +++ 2.6/cgi-bin/yabb2/Templates/default/default.html	(working copy)
 @@ -77,31 +77,17 @@
          </div>
          {yabb addtab}
          <div id="brcrumb" style="top: 0;">
 -        <table>
 -            <colgroup>
 -                <col style="width:2%" />
 -                <col style="width:98%" />
 -            </colgroup>
 -            <tr>
 -                <td class="nav h_30px">&nbsp;</td>
 -                <td class="nav">{yabb boardlink} {yabb navigation} <a href="#bottom">{yabb bottom}</a></td>
 -            </tr>
 -        </table>
 +            <div class="nav h_30px" style="padding-left: 2%">
 +                {yabb boardlink} {yabb navigation} <a href="#bottom">{yabb bottom}</a>
 +            </div>
          </div>
          <div class="yabb_main">{yabb main}
              <div class="yabb_forumjump">{yabb forumjump}&nbsp;</div>
          </div>
          <div class="mainbottom">
 -            <table>
 -                <colgroup>
 -                    <col style="width:2%" />
 -                    <col style="width:98%" />
 -                </colgroup>
 -                <tr>
 -                    <td>&nbsp;</td>
 -                    <td><span id="bottom">{yabb navback}</span></td>
 -                </tr>
 -            </table>
 +            <div style="padding-left: 2%">
 +                <span id="bottom">{yabb navback}</span>
 +            </div>
          </div>
      </div>
      <div class="copyright" style="width: 100%; text-align: center;">

Posted by: Monni
Posted on: Oct 1^st, 2014 at 4:19pm

Non-fatal typo, but the last diff to make the SVN equal to my personal tree...

Code

 Index: cgi-bin/yabb2/Admin/NewSettings.pm
 ===================================================================
 --- cgi-bin/yabb2/Admin/NewSettings.pm	(revision 1588)
 +++ cgi-bin/yabb2/Admin/NewSettings.pm	(working copy)
 @@ -720,7 +720,7 @@
  \$fix_brd_img_size = $fix_brd_img_size;
  \$img_greybox = $img_greybox;           # Set to 0 to disable "greybox" (each image is shown in a new window)
                              # Set to 1 to enable the attachment and post image "greybox" (one image/page)
 -                            # Set to 2 to enable the attachment and post image "greybox" => attachmet images: (all images/page), post images: (one image/page)
 +                            # Set to 2 to enable the attachment and post image "greybox" => attachment images: (all images/page), post images: (one image/page)

  ########## Extended Profiles ##########

Posted by: Dandello
Posted on: Sep 29^th, 2014 at 12:54am

Found more places with extra spaces. Will have those in the SVN tomorrow or so. Also discovered that the extra spaces are part of the problem with showing the different templates in ManageTemplates - a tag with extra spaces in it breaks, but only when being rendered in the iframe.

Posted by: Monni
Posted on: Sep 28^th, 2014 at 5:29pm

Wrong version number Wink

Code

 Index: Quick-Guide_26/English/extras/upgradeY1.html
 ===================================================================
 --- Quick-Guide_26/English/extras/upgradeY1.html	(revision 1585)
 +++ Quick-Guide_26/English/extras/upgradeY1.html	(working copy)
 @@ -1,7 +1,7 @@
  <!DOCTYPE html>
  <html lang='en-US'>
  <head>
 -<!-- YaBB 2.5 $Revision: 1416 $ -->
 +<!-- YaBB 2.6 $Revision: 1416 $ -->
  <title>YaBB Quick Start Guide - Upgrading from YaBB 1.x</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
  <link rel="stylesheet" href="../../style.css" type="text/css" />
 Index: Quick-Guide_26/English/info/license.html
 ===================================================================
 --- Quick-Guide_26/English/info/license.html	(revision 1585)
 +++ Quick-Guide_26/English/info/license.html	(working copy)
 @@ -1,7 +1,7 @@
  <!DOCTYPE html>
  <html lang='en-US'>
  <head>
 -<!-- YaBB 2.5 $Revision: 1463 $ -->
 +<!-- YaBB 2.6 $Revision: 1463 $ -->
  <title>YaBB Quick Start Guide - Info: License</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
  <link rel="stylesheet" href="../../style.css" type="text/css" />
 Index: Quick-Guide_26/English/install/before.html
 ===================================================================
 --- Quick-Guide_26/English/install/before.html	(revision 1585)
 +++ Quick-Guide_26/English/install/before.html	(working copy)
 @@ -4,7 +4,7 @@
  <!-- YaBB 2.6 $Revision: 1416 $ -->
  <title>YaBB Quick Start Guide - Installation: Before Installing</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
 -<meta name="description" content="YaBB 2.5.2 Quick Start Guide - Before Installation instructions" />
 +<meta name="description" content="YaBB 2.6.1 Quick Start Guide - Before Installation instructions" />
  <link rel="stylesheet" type="text/css" href="../../style.css" />
  </head>
  <body>

Posted by: Monni
Posted on: Sep 28^th, 2014 at 5:24pm

Remove extra characters...

Code

 Index: cgi-bin/yabb2/Sources/Poll.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/Poll.pm	(revision 1585)
 +++ cgi-bin/yabb2/Sources/Poll.pm	(working copy)
 @@ -698,7 +698,7 @@
      if($has_voted) {
       if ( !$hide_results || $poll_locked ) {
          $poll_notlocked = qq~
 -           <div style="float: right; width: 55px; text-align: right;; margin-right:4px">
 +           <div style="float: right; width: 55px; text-align: right; margin-right:4px">
                  <a href="$scripturl?num=$viewnum">$poll_bar</a> &nbsp;
                  <a href="$scripturl?num=$viewnum;view=pie">$poll_pie</a>
             </div>
 Index: cgi-bin/yabb2/Sources/YaBBC.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/YaBBC.pm	(revision 1585)
 +++ cgi-bin/yabb2/Sources/YaBBC.pm	(working copy)
 @@ -28,7 +28,7 @@
      my @HTMLtags;
      while ( $message =~ s/(<.+?>)/[HTML$i]/sm ) { push @HTMLtags, $1; $i++; }

 -    $message =~ s~(\W|^)\[smil(ie|ey)=(\S+?\.(gif|jpg|png|bmp))\]~$1<img class="smil" data-rel="\[smil$2=$3\]" src="$yyhtml_root/Smilies/$3"  alt="$post_txt{'287'}" title="$post_txt{'287'}" />~gism;
 +    $message =~ s~(\W|^)\[smil(ie|ey)=(\S+?\.(gif|jpg|png|bmp))\]~$1<img class="smil" data-rel="\[smil$2=$3\]" src="$yyhtml_root/Smilies/$3" alt="$post_txt{'287'}" title="$post_txt{'287'}" />~gism;
      $message =~ s~(\W|^);-?\)~$1<img class="smil" data-rel=";&#45;&#41;" src="$imagesdir/wink.gif" alt="$post_txt{'292'}" title="$post_txt{'292'}" />~gsm;
      $message =~ s~(\W|^)~$1<img class="smil" data-rel="" src="$imagesdir/grin.gif" alt="$post_txt{'293'}" title="$post_txt{'293'}" />~gsm;
      $message =~ s~(\W|^):'\(~$1<img class="smil" data-rel="&#58;'&#40;" src="$imagesdir/cry.gif" alt="$post_txt{'530'}" title="$post_txt{'530'}" />~gsm;
 Index: cgi-bin/yabb2/Templates/default/Micon.def
 ===================================================================
 --- cgi-bin/yabb2/Templates/default/Micon.def	(revision 1585)
 +++ cgi-bin/yabb2/Templates/default/Micon.def	(working copy)
 @@ -94,7 +94,7 @@
  'locked' => qq~$imagesdir/locked.gif~,
  'locked_moved' => qq~$imagesdir/locked_moved.gif~,
  'lockmail' => qq~$imagesdir/lockmail.png~,
 -'new_mess' => qq~$imagesdir/new.gif"~,
 +'new_mess' => qq~$imagesdir/new.gif~,
  'noimg' => qq~$imagesdir/noimg.gif~,
  'paperclip' => qq~$imagesdir/paperclip.gif~,
  'poll_mod' => qq~$imagesdir/poll_mod.gif~,
 @@ -143,9 +143,9 @@
  'eventprivate' => qq~<img src="$imagesdir/eventprivate.gif" alt="$var_cal_m{'calprivate'}" />~,
  'modify' => qq~<img src="$imagesdir/modify.png" alt="$var_cal_m{'caledit'}" title="$var_cal_m{'caledit'}" />~,
  'delete' => qq~<img src="$imagesdir/delete.gif" alt="$var_cal_m{'caldel'}" title="$var_cal_m{'caldel'}" />~,
 -'eventmore' => qq~<img  src="$imagesdir/eventmore.gif" alt="" />~,
 -'eventmorebd' => qq~<img  src="$imagesdir/eventmore.gif" alt="$var_cal_m{'calbirthdays'}" />~,
 -'eventmoreadd' => qq~<img  src="$imagesdir/eventmore.gif" alt="$var_cal_m{'getaddevent'}" />~,
 +'eventmore' => qq~<img src="$imagesdir/eventmore.gif" alt="" />~,
 +'eventmorebd' => qq~<img src="$imagesdir/eventmore.gif" alt="$var_cal_m{'calbirthdays'}" />~,
 +'eventmoreadd' => qq~<img src="$imagesdir/eventmore.gif" alt="$var_cal_m{'getaddevent'}" />~,
  'eventinfo' => qq~<img src="$imagesdir/eventinfo.gif" alt="$var_cal_m{'eventinfo'}" />~,
  'eventinfobd' => qq~<img src="$imagesdir/eventinfobd.gif" alt="" />~,
  'eventannounce' => qq~<img src="$yyhtml_root/EventIcons/eventannounce.gif" alt="$var_cal_m{'eventannounce'}" />~,
 Index: cgi-bin/yabb2/Templates/default/Poll.template
 ===================================================================
 --- cgi-bin/yabb2/Templates/default/Poll.template	(revision 1585)
 +++ cgi-bin/yabb2/Templates/default/Poll.template	(working copy)
 @@ -13,7 +13,6 @@
  ###############################################################################
  # $Revision$

 -$ubbcbak = 'ubbc2.png';
  $poll_bar = qq~<span class="ubbcbutton ubbcbuttonback"><img src="$imagesdir/bars.png" style="vertical-align:top" alt="bars" /></span>~;
  $poll_pie = qq~<span class="ubbcbutton ubbcbuttonback"><img src="$imagesdir/pie.png" style="vertical-align:top" alt="pie" /></span>~;
  $cat_col = $newload{'brd_col'};

Question:

Options:	Text	Color	Split Pie
Option 1:
Option 2:
Option 3:
Option 4:
Option 5:
Option 6:
Option 7:
Option 8:
Poll Comment:	Max 500 characters. Remaining characters:

Automatic End in:	days and minutes. Leave it blank if you don't want to set it now.
Enable Guest Voting:	Check this if you want guests to be able to vote in this poll.
Hide results:	Check this if you do not want the results of this poll shown until voting has been closed.
Multiple Choice	Check this if you want to allow users to vote for more than one option.
Time limit for deleting vote:	Time in minutes users are allowed to delete their vote (0 to disable delete).
Use legends for Pie Chart	Check this to use legends instead of labels next to each pie slice.
Pie Chart Radius:	Must be a value between 100 and 200 (default 100)

Name:
E-mail:
Your Verification Code is:	Please type the characters exactly as they appear in the image, without the first 2 and last 2 characters. The characters must be typed in the same order, and they are case-sensitive.
Verification Code:
Preview