(UTC)
Change Template: 
Choose Language:
YaBB Development & Mods › Bug Zone › YaBB Bugs › Cleanup... Bottom
‹ Previous Topic | Next Topic ›
Page Index Toggle Pages: 1 ReplyAdd Poll Send Topic
Normal Topic Cleanup... (Read 4094 times)
 
Paste Member Name in Quick Reply Box Monni
Language
***
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Mood: Frustrated
Zodiac sign: Pisces
Cleanup...
Sep 28th, 2014 at 5:24pm
Mark & QuoteQuote  
Remove extra characters...

Code
Select All
 Index: cgi-bin/yabb2/Sources/Poll.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/Poll.pm	(revision 1585)
 +++ cgi-bin/yabb2/Sources/Poll.pm	(working copy)
 @@ -698,7 +698,7 @@
      if($has_voted) {
       if ( !$hide_results || $poll_locked ) {
          $poll_notlocked = qq~
 -           <div style="float: right; width: 55px; text-align: right;; margin-right:4px">
 +           <div style="float: right; width: 55px; text-align: right; margin-right:4px">
                  <a href="$scripturl?num=$viewnum">$poll_bar</a> &nbsp;
                  <a href="$scripturl?num=$viewnum;view=pie">$poll_pie</a>
             </div>
 Index: cgi-bin/yabb2/Sources/YaBBC.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/YaBBC.pm	(revision 1585)
 +++ cgi-bin/yabb2/Sources/YaBBC.pm	(working copy)
 @@ -28,7 +28,7 @@
      my @HTMLtags;
      while ( $message =~ s/(<.+?>)/[HTML$i]/sm ) { push @HTMLtags, $1; $i++; }

 -    $message =~ s~(\W|^)\[smil(ie|ey)=(\S+?\.(gif|jpg|png|bmp))\]~$1<img class="smil" data-rel="\[smil$2=$3\]" src="$yyhtml_root/Smilies/$3"  alt="$post_txt{'287'}" title="$post_txt{'287'}" />~gism;
 +    $message =~ s~(\W|^)\[smil(ie|ey)=(\S+?\.(gif|jpg|png|bmp))\]~$1<img class="smil" data-rel="\[smil$2=$3\]" src="$yyhtml_root/Smilies/$3" alt="$post_txt{'287'}" title="$post_txt{'287'}" />~gism;
      $message =~ s~(\W|^);-?\)~$1<img class="smil" data-rel=";&#45;&#41;" src="$imagesdir/wink.gif" alt="$post_txt{'292'}" title="$post_txt{'292'}" />~gsm;
      $message =~ s~(\W|^)Grin~$1<img class="smil" data-rel="Grin" src="$imagesdir/grin.gif" alt="$post_txt{'293'}" title="$post_txt{'293'}" />~gsm;
      $message =~ s~(\W|^):'\(~$1<img class="smil" data-rel="&#58;'&#40;" src="$imagesdir/cry.gif" alt="$post_txt{'530'}" title="$post_txt{'530'}" />~gsm;
 Index: cgi-bin/yabb2/Templates/default/Micon.def
 ===================================================================
 --- cgi-bin/yabb2/Templates/default/Micon.def	(revision 1585)
 +++ cgi-bin/yabb2/Templates/default/Micon.def	(working copy)
 @@ -94,7 +94,7 @@
  'locked' => qq~$imagesdir/locked.gif~,
  'locked_moved' => qq~$imagesdir/locked_moved.gif~,
  'lockmail' => qq~$imagesdir/lockmail.png~,
 -'new_mess' => qq~$imagesdir/new.gif"~,
 +'new_mess' => qq~$imagesdir/new.gif~,
  'noimg' => qq~$imagesdir/noimg.gif~,
  'paperclip' => qq~$imagesdir/paperclip.gif~,
  'poll_mod' => qq~$imagesdir/poll_mod.gif~,
 @@ -143,9 +143,9 @@
  'eventprivate' => qq~<img src="$imagesdir/eventprivate.gif" alt="$var_cal_m{'calprivate'}" />~,
  'modify' => qq~<img src="$imagesdir/modify.png" alt="$var_cal_m{'caledit'}" title="$var_cal_m{'caledit'}" />~,
  'delete' => qq~<img src="$imagesdir/delete.gif" alt="$var_cal_m{'caldel'}" title="$var_cal_m{'caldel'}" />~,
 -'eventmore' => qq~<img  src="$imagesdir/eventmore.gif" alt="" />~,
 -'eventmorebd' => qq~<img  src="$imagesdir/eventmore.gif" alt="$var_cal_m{'calbirthdays'}" />~,
 -'eventmoreadd' => qq~<img  src="$imagesdir/eventmore.gif" alt="$var_cal_m{'getaddevent'}" />~,
 +'eventmore' => qq~<img src="$imagesdir/eventmore.gif" alt="" />~,
 +'eventmorebd' => qq~<img src="$imagesdir/eventmore.gif" alt="$var_cal_m{'calbirthdays'}" />~,
 +'eventmoreadd' => qq~<img src="$imagesdir/eventmore.gif" alt="$var_cal_m{'getaddevent'}" />~,
  'eventinfo' => qq~<img src="$imagesdir/eventinfo.gif" alt="$var_cal_m{'eventinfo'}" />~,
  'eventinfobd' => qq~<img src="$imagesdir/eventinfobd.gif" alt="" />~,
  'eventannounce' => qq~<img src="$yyhtml_root/EventIcons/eventannounce.gif" alt="$var_cal_m{'eventannounce'}" />~,
 Index: cgi-bin/yabb2/Templates/default/Poll.template
 ===================================================================
 --- cgi-bin/yabb2/Templates/default/Poll.template	(revision 1585)
 +++ cgi-bin/yabb2/Templates/default/Poll.template	(working copy)
 @@ -13,7 +13,6 @@
  ###############################################################################
  # $Revision$

 -$ubbcbak = 'ubbc2.png';
  $poll_bar = qq~<span class="ubbcbutton ubbcbuttonback"><img src="$imagesdir/bars.png" style="vertical-align:top" alt="bars" /></span>~;
  $poll_pie = qq~<span class="ubbcbutton ubbcbuttonback"><img src="$imagesdir/pie.png" style="vertical-align:top" alt="pie" /></span>~;
  $cat_col = $newload{'brd_col'};
  
Back to top
GTalk Skype/VoIP Facebook Twitter YouTube ICQ  
IP Logged
 
Paste Member Name in Quick Reply Box Monni
Language
***
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Mood: Frustrated
Zodiac sign: Pisces
Re: Cleanup...
Reply #1 - Sep 28th, 2014 at 5:29pm
Mark & QuoteQuote  
Wrong version number Wink

Code
Select All
 Index: Quick-Guide_26/English/extras/upgradeY1.html
 ===================================================================
 --- Quick-Guide_26/English/extras/upgradeY1.html	(revision 1585)
 +++ Quick-Guide_26/English/extras/upgradeY1.html	(working copy)
 @@ -1,7 +1,7 @@
  <!DOCTYPE html>
  <html lang='en-US'>
  <head>
 -<!-- YaBB 2.5 $Revision: 1416 $ -->
 +<!-- YaBB 2.6 $Revision: 1416 $ -->
  <title>YaBB Quick Start Guide - Upgrading from YaBB 1.x</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
  <link rel="stylesheet" href="../../style.css" type="text/css" />
 Index: Quick-Guide_26/English/info/license.html
 ===================================================================
 --- Quick-Guide_26/English/info/license.html	(revision 1585)
 +++ Quick-Guide_26/English/info/license.html	(working copy)
 @@ -1,7 +1,7 @@
  <!DOCTYPE html>
  <html lang='en-US'>
  <head>
 -<!-- YaBB 2.5 $Revision: 1463 $ -->
 +<!-- YaBB 2.6 $Revision: 1463 $ -->
  <title>YaBB Quick Start Guide - Info: License</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
  <link rel="stylesheet" href="../../style.css" type="text/css" />
 Index: Quick-Guide_26/English/install/before.html
 ===================================================================
 --- Quick-Guide_26/English/install/before.html	(revision 1585)
 +++ Quick-Guide_26/English/install/before.html	(working copy)
 @@ -4,7 +4,7 @@
  <!-- YaBB 2.6 $Revision: 1416 $ -->
  <title>YaBB Quick Start Guide - Installation: Before Installing</title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
 -<meta name="description" content="YaBB 2.5.2 Quick Start Guide - Before Installation instructions" />
 +<meta name="description" content="YaBB 2.6.1 Quick Start Guide - Before Installation instructions" />
  <link rel="stylesheet" type="text/css" href="../../style.css" />
  </head>
  <body>
  
Back to top
GTalk Skype/VoIP Facebook Twitter YouTube ICQ  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Cleanup...
Reply #2 - Sep 29th, 2014 at 12:54am
Mark & QuoteQuote  
Found more places with extra spaces. Will have those in the SVN tomorrow or so. Also discovered that the extra spaces are part of the problem with showing the different templates in ManageTemplates - a tag with extra spaces in it breaks, but only when being rendered in the iframe.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Monni
Language
***
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Mood: Frustrated
Zodiac sign: Pisces
Re: Cleanup...
Reply #3 - Oct 1st, 2014 at 4:19pm
Mark & QuoteQuote  
Non-fatal typo, but the last diff to make the SVN equal to my personal tree...

Code
Select All
 Index: cgi-bin/yabb2/Admin/NewSettings.pm
 ===================================================================
 --- cgi-bin/yabb2/Admin/NewSettings.pm	(revision 1588)
 +++ cgi-bin/yabb2/Admin/NewSettings.pm	(working copy)
 @@ -720,7 +720,7 @@
  \$fix_brd_img_size = $fix_brd_img_size;
  \$img_greybox = $img_greybox;           # Set to 0 to disable "greybox" (each image is shown in a new window)
                              # Set to 1 to enable the attachment and post image "greybox" (one image/page)
 -                            # Set to 2 to enable the attachment and post image "greybox" => attachmet images: (all images/page), post images: (one image/page)
 +                            # Set to 2 to enable the attachment and post image "greybox" => attachment images: (all images/page), post images: (one image/page)

  ########## Extended Profiles ##########
  
Back to top
GTalk Skype/VoIP Facebook Twitter YouTube ICQ  
IP Logged
 
Paste Member Name in Quick Reply Box Monni
Language
***
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Mood: Frustrated
Zodiac sign: Pisces
Re: Cleanup...
Reply #4 - Oct 1st, 2014 at 5:59pm
Mark & QuoteQuote  
Replace tables with empty cells with divs... Only for 2.6.2, because this will break some mods...

Code
Select All
 Index: 2.6/cgi-bin/yabb2/Templates/default/default.html
 ===================================================================
 --- 2.6/cgi-bin/yabb2/Templates/default/default.html	(revision 1587)
 +++ 2.6/cgi-bin/yabb2/Templates/default/default.html	(working copy)
 @@ -77,31 +77,17 @@
          </div>
          {yabb addtab}
          <div id="brcrumb" style="top: 0;">
 -        <table>
 -            <colgroup>
 -                <col style="width:2%" />
 -                <col style="width:98%" />
 -            </colgroup>
 -            <tr>
 -                <td class="nav h_30px">&nbsp;</td>
 -                <td class="nav">{yabb boardlink} {yabb navigation} <a href="#bottom">{yabb bottom}</a></td>
 -            </tr>
 -        </table>
 +            <div class="nav h_30px" style="padding-left: 2%">
 +                {yabb boardlink} {yabb navigation} <a href="#bottom">{yabb bottom}</a>
 +            </div>
          </div>
          <div class="yabb_main">{yabb main}
              <div class="yabb_forumjump">{yabb forumjump}&nbsp;</div>
          </div>
          <div class="mainbottom">
 -            <table>
 -                <colgroup>
 -                    <col style="width:2%" />
 -                    <col style="width:98%" />
 -                </colgroup>
 -                <tr>
 -                    <td>&nbsp;</td>
 -                    <td><span id="bottom">{yabb navback}</span></td>
 -                </tr>
 -            </table>
 +            <div style="padding-left: 2%">
 +                <span id="bottom">{yabb navback}</span>
 +            </div>
          </div>
      </div>
      <div class="copyright" style="width: 100%; text-align: center;">
  
Back to top
GTalk Skype/VoIP Facebook Twitter YouTube ICQ  
IP Logged
 
Paste Member Name in Quick Reply Box Dandello
Forum Administrator
YaBB Modder
*****
Offline


I love YaBB 2.7!

Posts: 2235
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Mood: Annoyed
Zodiac sign: Virgo
Re: Cleanup...
Reply #5 - Oct 1st, 2014 at 6:55pm
Mark & QuoteQuote  
On the list for 2.6.2 - replace all single cell tables with divs, replace all spacer-only cells with padding or margin css. Clean up multiple nested tables with divs.

We'll also be looking at using html5 tags like nav, header, footer, article.

THEN, we'll look at mobile/mini-screen versions which may require some interesting detection and template calling.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Paste Member Name in Quick Reply Box Monni
Language
***
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Mood: Frustrated
Zodiac sign: Pisces
Re: Cleanup...
Reply #6 - Oct 1st, 2014 at 7:02pm
Mark & QuoteQuote  
Dandello wrote on Oct 1st, 2014 at 6:55pm:
On the list for 2.6.2 - replace all single cell tables with divs, replace all spacer-only cells with padding or margin css. Clean up multiple nested tables with divs.

We'll also be looking at using html5 tags like nav, header, footer, article.

THEN, we'll look at mobile/mini-screen versions which may require some interesting detection and template calling.


I'm slowly trying to clean up the custom template I made for one of my clients... It is blend of three templates, old blue_1, old custom template used on that forum and the new default template in 2.6.0/2.6.1... I will post some of the changes I make as they might be useful in default template for 2.6.2.
  
Back to top
GTalk Skype/VoIP Facebook Twitter YouTube ICQ  
IP Logged
 
Page Index Toggle Pages: 1
ReplyAdd Poll Send Topic
‹ Previous Topic | Next Topic ›
Bookmarks: del.icio.us Digg Facebook Google LinkedIn reddit Twitter Yahoo
Cleanup...

Please type the characters exactly as they appear in the image,
without the first 2 and last 2 characters.
The characters must be typed in the same order,
and they are case-sensitive.
Open Preview Preview

You can resize the textbox by dragging the right or bottom border.
Off Topic Comment Insert Spoiler
Insert Hyperlink Insert FTP Link Insert Image Insert E-mail Insert Media Insert Table Insert Table Row Insert Table Column Insert Horizontal Rule Insert Teletype Insert Code Insert Quote Edited Superscript Subscript Insert List /me - my name Insert Marquee Insert Timestamp No Parse
Bold Italicized Underline Insert Strikethrough Highlight
                       
Change Text Color
Insert Preformatted Text Left Align Centered Right Align
resize_wb
resize_hb







Max 5000 characters. Remaining characters:
Text size: %
More Smilies
View All Smilies
Collapse additional features Collapse/Expand additional features Smiley Wink Cheesy Grin Angry Sad Shocked Cool Huh Roll Eyes Tongue Embarrassed Lips Sealed Undecided Kiss Cry
 

YaBB Development & Mods » Powered by YaBB 2.7.00!
YaBB Forum Software © 2000-2024. All Rights Reserved.

Valid RSS HTML 5 Valid CSS Powered by Perl Source Forge

Page completed in 1.4848 seconds.