Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: SVN 2.6.11 branch Mar 18th, 2015 at 5:38pm Mark & QuoteQuote If someone (like Monni) would be so kind as to double check the files in the zip before they get uploaded to the SVN There are a lot of little fixes - things like line ends, removing hard tabs, fixing hardcoded language, javascript and html validation. And of course, bug fixes. The file is at 2.6.11_fixa.zip (It's too big to just add an an attachment.) Edited: I forgot the dupes in the Paths.pm editor in AdminEdit.pm - that fix isn't in the zip. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #1 - Mar 19th, 2015 at 1:27pm Mark & QuoteQuote Dandello wrote on Mar 18th, 2015 at 5:38pm:If someone (like Monni) would be so kind as to double check the files in the zip before they get uploaded to the SVN There are a lot of little fixes - things like line ends, removing hard tabs, fixing hardcoded language, javascript and html validation. And of course, bug fixes. The file is at 2.6.11_fixa.zip (It's too big to just add an an attachment.) Edited: I forgot the dupes in the Paths.pm editor in AdminEdit.pm - that fix isn't in the zip. I'm pretty sure it's still bad... I have to finish comparing the files, but some things just don't look good... GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #2 - Mar 19th, 2015 at 1:48pm Mark & QuoteQuote The fixes for the non-Latinate attachment name transliteration may still need some work. And there may be an issue with the attachment name transliteration and multiple char encodings on the forum. Maybe a note for non-Latinate users that the name of the file they're uploading needs to be in ASCII otherwise it will upload as '_______.*' Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #3 - Mar 19th, 2015 at 4:19pm Mark & QuoteQuote This is what I got when comparing... 2_6_11a_diff.zip ( 4 KB | 205 Downloads ) GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #4 - Mar 19th, 2015 at 7:10pm Mark & QuoteQuote Just went through your catches (new zip is at 2.6.11_fixb.zip). I removed the Holly Hack from Templates/Admin/default.css - there's a problem with going between ANSI and UTF-8 char encoding with it and this bit of code isn't in Templates/Forum/default.css. We do need to check to make sure we don't have any uncleared floats triggering the newer version of the Guillotine Bug in MSIE. (But the reports on that one date from 2010 and as far as I'm aware, nobody's reported having problems with it on YaBBForum.) Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #5 - Mar 19th, 2015 at 10:20pm Mark & QuoteQuote One more diff... lol... doing four-way merge, so didn't catch all the differences at first attempt... Can't even imagine how many hours it took to compare all the revisions... 2_6_11b_diff.zip ( 3 KB | 147 Downloads ) GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #6 - Mar 19th, 2015 at 10:36pm Mark & QuoteQuote Oh, I can imagine - I'm having to write down which install is which and what it was testing... (I only have about 20 different versions of YaBB on my home server. ) Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #7 - Mar 19th, 2015 at 10:41pm Mark & QuoteQuote Dandello wrote on Mar 19th, 2015 at 10:36pm:Oh, I can imagine - I'm having to write down which install is which and what it was testing... (I only have about 20 different versions of YaBB on my home server. ) I only have 12 versions of YaBB here, so keep patching GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #8 - Mar 20th, 2015 at 1:10pm Mark & QuoteQuote On a related note: should we have all the inline javascript inside the ![CDATA] code? Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #9 - Mar 20th, 2015 at 2:07pm Mark & QuoteQuote Dandello wrote on Mar 20th, 2015 at 1:10pm:On a related note: should we have all the inline javascript inside the ![CDATA] code? It's only required if the JavaScript code contains characters that have special meaning in XML or XHTML... Chrome seems to be very picky about pages that don't use CDATA. The result is pretty unpredictable. Same goes for not having trailing ; in inline styles or JavaScript code, especially inside element attributes. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #10 - Mar 20th, 2015 at 2:11pm Mark & QuoteQuote So none of this will be an issue once we go all HTML5 in 2.6.2 (except possibly in the RSS feed)? (Except for the trailing ';' in inline styles and javascript?) Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #11 - Mar 20th, 2015 at 2:19pm Mark & QuoteQuote Dandello wrote on Mar 20th, 2015 at 2:11pm:So none of this will be an issue once we go all HTML5 in 2.6.2 (except possibly in the RSS feed)? (Except for the trailing ';' in inline styles and javascript?) As far as I know about HTML5, those kind of inline JavaScript blocks are forbidden completely. (Section 8.1.2.6) GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #12 - Mar 20th, 2015 at 2:35pm Mark & QuoteQuote An awful lot of HTML5 tutorials show inline javascript examples although I think many of the ones YaBB uses could be pushed to the bottom of the page. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: SVN 2.6.11 branch Reply #13 - Mar 20th, 2015 at 2:45pm Mark & QuoteQuote Dandello wrote on Mar 20th, 2015 at 2:35pm:An awful lot of HTML5 tutorials show inline javascript examples although I think many of the ones YaBB uses could be pushed to the bottom of the page. XML and HTML5 have different reserved characters, so I see no problem with having inline JavaScript as long as it is validated to not contain "</", which would cause the block to terminate prematurely. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2234 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: SVN 2.6.11 branch Reply #14 - Mar 20th, 2015 at 3:11pm Mark & QuoteQuote and this: Code XML and HTML5 have different reserved characters, so I see no problem with having inline JavaScript as long as it is validated to not contain "</", which would cause the block to terminate prematurely. made an interesting bit in the notification email: Code XML and HTML5 have different reserved characters, so I see no problem with having inline JavaScript as long as it is validated to not contain "http://yabbforumsoftware.com/cgi-bin/yabb2/YaBB.pl?num=1426700337/13#13 Methinks the notification emails need more css - and other things. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Pages: [1] 
SVN 2.6.11 branch (Read 14711 times)
HTML 5
HTML 5