Dandello wrote on Aug 3^rd, 2014 at 9:39pm:


Now can I get a mention in Special thanks for 2.6.1 for finding and fixing most of the bugs after release of 2.6.0. 

Little better...

But like this...

 Index: Subs.pm
 ===================================================================
 --- Subs.pm	(revision 1520)
 +++ Subs.pm	(working copy)
 @@ -818,6 +818,19 @@
  s/"((avatar|avatarml|post|attach|signat|brd)_img_resize)"([^>]*>)/ check_image_resize($1,$2,$3) /gesm;

      if ($resize_num) {
 +		$avatar_img_w    = $max_avatar_width // 0;
 +		$avatar_img_h    = $max_avatar_height // 0;
 +		$avatarml_img_w  = $max_avatarml_width // 0;
 +		$avatarml_img_h  = $max_avatarml_height // 0;
 +		$post_img_w      = $max_post_img_width // 0;
 +		$post_img_h      = $max_post_img_height // 0;
 +		$attach_img_w    = $max_attach_img_width // 0;
 +		$attach_img_h    = $max_attach_img_height // 0;
 +		$signat_img_w    = $max_signat_img_width // 0;
 +		$signat_img_h    = $max_signat_img_height // 0;
 +		$brd_img_w       = $max_brd_img_width // 0;
 +		$brd_img_h       = $max_brd_img_height // 0;
 +
          $resize_js =~ s/,$//xsm;
          $resize_js = qq~<script type="text/javascript">
      // resize image start
 @@ -824,23 +837,23 @@
      var resize_time = 2;
      var img_resize_names = new Array ($resize_js);

 -    var avatar_img_w    = $max_avatar_width;
 -    var avatar_img_h    = $max_avatar_height;
 +    var avatar_img_w    = $avatar_img_w;
 +    var avatar_img_h    = $avatar_img_h;
      var fix_avatar_size = $fix_avatar_img_size;
 -    var avatarml_img_w    = $max_avatarml_width;
 -    var avatarml_img_h    = $max_avatarml_height;
 +    var avatarml_img_w    = $avatarml_img_w;
 +    var avatarml_img_h    = $avatarml_img_h;
      var fix_avatarml_size = $fix_avatarml_img_size;
 -    var post_img_w      = $max_post_img_width;
 -    var post_img_h      = $max_post_img_height;
 +    var post_img_w      = $post_img_w;
 +    var post_img_h      = $post_img_h;
      var fix_post_size   = $fix_post_img_size;
 -    var attach_img_w    = $max_attach_img_width;
 -    var attach_img_h    = $max_attach_img_height;
 +    var attach_img_w    = $attach_img_w;
 +    var attach_img_h    = $attach_img_h;
      var fix_attach_size = $fix_attach_img_size;
 -    var signat_img_w    = $max_signat_img_width;
 -    var signat_img_h    = $max_signat_img_height;
 +    var signat_img_w    = $signat_img_w;
 +    var signat_img_h    = $signat_img_h;
      var fix_signat_size = $fix_signat_img_size;
 -    var brd_img_w       = $max_brd_img_width;
 -    var brd_img_h       = $max_brd_img_height;
 +    var brd_img_w       = $brd_img_w;
 +    var brd_img_h       = $brd_img_h;
      var fix_brd_size    = $fix_brd_img_size;

      noimgdir   = '$imagesdir';
  

Another thing is that it should use // operator instead of || operator... as // means defined-or and || means true-or.

Dandello wrote on Aug 3^rd, 2014 at 7:00pm:


The problem is that the Perl parser can't know which part of the code is for Perl and which part is for the JavaScript code... it has to break the literal string to make it unambiguous.

Monni wrote on Aug 3^rd, 2014 at 6:11pm:


No, it just hates me. (And it can't read my mind when I only want one post and forget to select that one post.  )

Dandello wrote on Aug 3^rd, 2014 at 2:21pm:


People on the forum I upgraded noticed the missing semicolons because images in attachments stopped showing correctly. When I tried to debug the JavaScript code, it did suggest the error is on line number that is past end of the source code... After adding the missing semicolons it did correctly show the error is actually in the code that initializes board image scaling due to uninitialized variables. Like I mentioned in the first post the Perl code for injecting the values in JavaScript code is too simple and didn't default to 0 when the entry in settings file could not be read.

On the javascript - I just uploaded edited copies of ExtendedProfiles and PostBox for testing. My initial tests on my home server didn't catch any js errors in Chrome.

Dandello wrote on Aug 2^nd, 2014 at 10:44pm:

In the first forum back in 2004 it took them about a week to promote me as an administrator... Because I was being such an annoying person...
I ended up kicking out 90% of the users, including main sponsor of the company running the forum.