(UTC)
Change Template: 
Choose Language:
Add Poll
 
Options: Text Color Split Pie
 
 
 
 
 
 
 
 
Poll Comment:
Max 500 characters. Remaining characters:
days and minutes. Leave it blank if you don't want to set it now.

Please type the characters exactly as they appear in the image,
without the first 2 and last 2 characters.
The characters must be typed in the same order,
and they are case-sensitive.
Open Preview Preview

You can resize the textbox by dragging the right or bottom border.
Off Topic Comment Insert Spoiler
Insert Hyperlink Insert FTP Link Insert Image Insert E-mail Insert Media Insert Table Insert Table Row Insert Table Column Insert Horizontal Rule Insert Teletype Insert Code Insert Quote Edited Superscript Subscript Insert List /me - my name Insert Marquee Insert Timestamp No Parse
Bold Italicized Underline Insert Strikethrough Highlight
                       
Change Text Color
Insert Preformatted Text Left Align Centered Right Align
resize_wb
resize_hb







Max 5000 characters. Remaining characters:
Text size: %
More Smilies
View All Smilies
Collapse additional features Collapse/Expand additional features Smiley Wink Cheesy Grin Angry Sad Shocked Cool Huh Roll Eyes Tongue Embarrassed Lips Sealed Undecided Kiss Cry
Topic Summary - Displaying 6 post(s). Click here to show all
Posted by: Dandello
Posted on: Mar 6th, 2015 at 1:42am
I'll check it out in the morning - when I'm not so tired I can't see straight.
Posted by: Monni
Posted on: Mar 6th, 2015 at 12:59am
http://pastebin.com/X9391iyH

There might be some things that could be done differently, but this pretty much shows where it breaks syntax highlighting and what can be fixed without actually breaking perl syntax.
Posted by: Dandello
Posted on: Mar 5th, 2015 at 11:17pm
Monni wrote on Mar 5th, 2015 at 10:57pm:
instead of literal #, I presume we should use \x23, but that makes HTML entities look unreadable.
                     


That's one of the issues with working with a frame work that combines 3 languages - there are characters that mean different things in each language - one of them is #.
Posted by: Monni
Posted on: Mar 5th, 2015 at 10:57pm
Dandello wrote on Mar 5th, 2015 at 8:35pm:
Actually, in the language files we should be using q~ ~; and qq~ ~; to avoid the escaped quotes. Same in the main line code. (q~ ~; is non-interpolated and qq~ ~; is interpolated. YaBB uses the tildes in stead of curly brackets because it uses curly brackets to mark the template replacement sections.

But a diff would be good so we can get it all cleaned up.


While I was making the diff, I also noticed that literal # is used outside comment declarations... instead of literal #, I presume we should use \x23, but that makes HTML entities look unreadable.
Posted by: Dandello
Posted on: Mar 5th, 2015 at 8:35pm
Actually, in the language files we should be using q~ ~; and qq~ ~; to avoid the escaped quotes. Same in the main line code. (q~ ~; is non-interpolated and qq~ ~; is interpolated. YaBB uses the tildes in stead of curly brackets because it uses curly brackets to mark the template replacement sections.

But a diff would be good so we can get it all cleaned up.
Posted by: Monni
Posted on: Mar 5th, 2015 at 7:08pm
Not so much a bug, but styling glitch...

There is a lot of unmatched single and double quotes that make code full of ugly hacks...

Instead of using

\" or '"' or unbalanced " -- we should use \x22
\' or "'" or unbalanced ' -- we should use \x27

This should also make syntax checkers happy

There was also some cases where quotes were unbalanced because variable inside the quotes was not evaluated beforehand and used ?: instead.

I'm going to make a diff when I get the code cleaned up...
 

YaBB Development & Mods » Powered by YaBB 2.7.00!
YaBB Forum Software © 2000-2024. All Rights Reserved.

Valid RSS HTML 5 Valid CSS Powered by Perl Source Forge

Page completed in 0.9112 seconds.