Topic Summary - Displaying 15 post(s). Click here to show all
Posted by: Cecily Posted on: Oct 17th, 2014 at 4:03pm
Guest test
Posted by: Dandello Posted on: Oct 7th, 2014 at 3:03pm
The new sub for calling viewprofile is in testing here. (Admin choice of redirect to new screen or disable link and use 'title' instead.) I THINK I caught all the viewprofile links that weren't already handled via the QuickLinks guest catching routine.
Posted by: Dandello Posted on: Oct 6th, 2014 at 4:30pm
Oh, if it used a single function or sub call that would be too easy.
For this I started looking through all the files for 'action=viewprofile' and kept my fingers crossed that the related code wasn't so convoluted I got a headache looking at it.
I'll get back to this later today or tomorrow. Got Real World things to do today.
Oooh... A new sub .
Posted by: Monni Posted on: Oct 6th, 2014 at 3:17pm
This is just a first iteration for testing. I'll be going back and reediting things once I've gotten some 'admin choices' figured out. (And there maybe one live link still hiding somewhere - It's showing in the errorlog but it could also be a link generated by a bot trying to get in.)
I usually convert them as functions and then use "grep" to find where the unique part of the link is used raw on the sources... when it uses a function, it should only show one result
Posted by: Dandello Posted on: Oct 6th, 2014 at 2:37pm
This is just a first iteration for testing. I'll be going back and reediting things once I've gotten some 'admin choices' figured out. (And there maybe one live link still hiding somewhere - It's showing in the errorlog but it could also be a link generated by a bot trying to get in.)
Posted by: Monni Posted on: Oct 6th, 2014 at 10:08am
Current tests - using the title tag to create 'non-error popups' explaining to guests that access to member profiles is for memebr profiles. - Not admin editable yet or admin choice as to having a 'redirect' to registration page.
Instead of using two spans, you should combine the parameters to one span...
Posted by: Dandello Posted on: Oct 6th, 2014 at 4:52am
Current tests - using the title tag to create 'non-error popups' explaining to guests that access to member profiles is for memebr profiles. - Not admin editable yet or admin choice as to having a 'redirect' to registration page.
Posted by: Dandello Posted on: Sep 17th, 2014 at 8:35pm
Off to look for more of them.
Posted by: Monni Posted on: Sep 17th, 2014 at 7:51pm
When not logged in, link to profile of last person who edited a poll is still visible.
Posted by: Monni Posted on: Sep 17th, 2014 at 10:16am
I will test how much shorter the error log gets
Posted by: Dandello Posted on: Sep 17th, 2014 at 2:42am
Uploaded here (and in the SVN) changes to BoardIndex.pm, MessageIndex.pm and Load.pm to disable links to the Profile Page when it's a guest viewing.
Posted by: Dandello Posted on: Sep 16th, 2014 at 8:59pm
My delay was that I already had 20 script pages open for editing and about 5 browser windows. (And lunch, and...)
Posted by: Monni Posted on: Sep 16th, 2014 at 8:02pm
With quick test by logging out, the main problem was where it shows last poster of each board, or starter and last poster of each thread... Clicking the name of the user will give 403 as expected, but it should not be a link at all to avoid the extra page load for crawlers and other guests.
Posted by: Dandello Posted on: Sep 16th, 2014 at 7:29pm
Good idea - I'll double check that all the profile links are, in fact, disabled when they're supposed to be.
Posted by: Monni Posted on: Sep 16th, 2014 at 3:39pm
If admin has disabled access to user profiles, links to them should be hidden for guests... This eases the server load a lot as crawlers won't try to load pages that they have no rights to view. This is especially problematic as the URL for the profile changes every time and crawlers can't cache the server result.