Add Poll
 
Options: Text Color Split Pie
 
 
 
 
 
 
 
 
Poll Comment:
Max 500 characters. Remaining characters:
days and minutes. Leave it blank if you don't want to set it now.

Please type the characters exactly as they appear in the image,
without the first 2 and last 2 characters.
The characters must be typed in the same order,
and they are case-sensitive.
Open Preview Preview

You can resize the textbox by dragging the right or bottom border.
Off Topic Comment Insert Spoiler
Insert Hyperlink Insert FTP Link Insert Image Insert E-mail Insert Media Insert Table Insert Table Row Insert Table Column Insert Horizontal Rule Insert Teletype Insert Code Insert Quote Edited Superscript Subscript Insert List /me - my name Insert Marquee Insert Timestamp No Parse
Bold Italicized Underline Insert Strikethrough Highlight
                       
Change Text Color
Insert Preformatted Text Left Align Centered Right Align
resize_wb
resize_hb







Max 5000 characters. Remaining characters:
Text size: %
More Smilies
View All Smilies
Collapse additional features Collapse/Expand additional features Smiley Wink Cheesy Grin Angry Sad Shocked Cool Huh Roll Eyes Tongue Embarrassed Lips Sealed Undecided Kiss Cry
Topic Summary - Displaying 10 post(s). Click here to show all
Posted by: Dandello
Posted on: Aug 17th, 2014 at 7:11pm
Sometimes I realize I did something wrong when I'm out and about.
Posted by: Monni
Posted on: Aug 17th, 2014 at 4:52pm
Yeah...
When I write my own code, I write first, then think later... Sometimes it takes few hours to notice error in my own code, it happens sometimes after I have already turned off the computer or put it in sleep mode.
I guess I have developed my own style of quality control during the 31 years I have developed programs.
Posted by: Dandello
Posted on: Aug 17th, 2014 at 4:42pm
And this is why having more than one set of eyes looking at the code is such a good thing. Smiley
Posted by: Monni
Posted on: Aug 17th, 2014 at 4:34pm
One more time...

in trunk, the second change, the semicolon is now in wrong place...

it is before ), when it should be after it...
Posted by: Dandello
Posted on: Aug 17th, 2014 at 4:19pm
Got the beggars this time.  Embarrassed
Posted by: Monni
Posted on: Aug 17th, 2014 at 3:57pm
I noticed you committed the fix to SVN but you forgot to add the semicolons.
Posted by: Dandello
Posted on: Aug 17th, 2014 at 3:25pm
Picky isn't bad if it makes us write better code.  Wink
Posted by: Monni
Posted on: Aug 17th, 2014 at 2:48pm
Chrome seems to be more picky about things... But I guess all browsers that share same JavaScript engine are equally picky... Quick look at the integrated debugger in Chrome's Developer Tools revealed again pretty amusingly how Chrome tried miserably to recover from missing semicolon...
Posted by: Dandello
Posted on: Aug 17th, 2014 at 2:28pm
Thanks -  learning more about js all the time.  Smiley

Edited:
Just uploaded the fix here for testing
Posted by: Monni
Posted on: Aug 17th, 2014 at 10:55am
Uncaught TypeError: Cannot read property 'complete' of undefined YaBB.js:448
resize_brd_images YaBB.js:448
onload YaBB.pl:351

Code
Select All
 Index: cgi-bin/yabb2/Sources/BoardIndex.pm
 ===================================================================
 --- cgi-bin/yabb2/Sources/BoardIndex.pm	(revision 1534)
 +++ cgi-bin/yabb2/Sources/BoardIndex.pm	(working copy)
 @@ -1203,11 +1203,11 @@
  				$imgid = $brd_img_id{$curboard};
                  if ( $bdpic =~ /\//ism ) {
                      $bdpic =
 -qq~ <img src="$bdpic" alt="$boardname" title="$boardname" id="brd_id_$imgid" onload="resize_brd_images(brd_id_$imgid)" $brd_stylea$brd_w$brd_h$brd_styleb /> ~;
 +qq~ <img src="$bdpic" alt="$boardname" title="$boardname" id="brd_id_$imgid" onload="resize_brd_images(this);" $brd_stylea$brd_w$brd_h$brd_styleb /> ~;
                  }
                  elsif ($bdpic) {
                      $bdpic =
 -qq~ <img src="$imagesdir/$bdpicfld$bdpic" alt="$boardname" title="$boardname" id="brd_id_$imgid" onload="resize_brd_images(brd_id_$imgid)" /> ~;
 +qq~ <img src="$imagesdir/$bdpicfld$bdpic" alt="$boardname" title="$boardname" id="brd_id_$imgid" onload="resize_brd_images(this);" /> ~;
                  }

                  if ( $boardname !~ m/[ht|f]tp[s]{0,1}:\/\//sm ) {
  



Trick here is to use "this" instead of literal element id, because Chrome doesn't implicit cast the literal text as DOM object.
Like usually omitting the semicolon makes Chrome fail miserably.