Topic Summary - Displaying 10 post(s). Click here to show all
Posted by: Dandello Posted on: Aug 17th, 2014 at 7:11pm
Sometimes I realize I did something wrong when I'm out and about.
Posted by: Monni Posted on: Aug 17th, 2014 at 4:52pm
Yeah... When I write my own code, I write first, then think later... Sometimes it takes few hours to notice error in my own code, it happens sometimes after I have already turned off the computer or put it in sleep mode. I guess I have developed my own style of quality control during the 31 years I have developed programs.
Posted by: Dandello Posted on: Aug 17th, 2014 at 4:42pm
And this is why having more than one set of eyes looking at the code is such a good thing.
Posted by: Monni Posted on: Aug 17th, 2014 at 4:34pm
One more time...
in trunk, the second change, the semicolon is now in wrong place...
it is before ), when it should be after it...
Posted by: Dandello Posted on: Aug 17th, 2014 at 4:19pm
Got the beggars this time.
Posted by: Monni Posted on: Aug 17th, 2014 at 3:57pm
I noticed you committed the fix to SVN but you forgot to add the semicolons.
Posted by: Dandello Posted on: Aug 17th, 2014 at 3:25pm
Picky isn't bad if it makes us write better code.
Posted by: Monni Posted on: Aug 17th, 2014 at 2:48pm
Chrome seems to be more picky about things... But I guess all browsers that share same JavaScript engine are equally picky... Quick look at the integrated debugger in Chrome's Developer Tools revealed again pretty amusingly how Chrome tried miserably to recover from missing semicolon...
Posted by: Dandello Posted on: Aug 17th, 2014 at 2:28pm
Thanks - learning more about js all the time.
Edited:
Just uploaded the fix here for testing
Posted by: Monni Posted on: Aug 17th, 2014 at 10:55am
Trick here is to use "this" instead of literal element id, because Chrome doesn't implicit cast the literal text as DOM object. Like usually omitting the semicolon makes Chrome fail miserably.