Didn't seem to be a clear place for bug reports on old revisions, so I figured I'd just post it here and let you move it if necessary.
I updated from 2.5AE to 2.6.11 a while back. In doing so, the ability to edit posts broke - no one, not even mods or admins, can modify a post. While it has made for some amusing incidents, it is a bit of a pain. Well, eventually, one of my members got sick of it, did some debugging, and identified the issue. I'm reporting it here in case it has not been found yet.
In cgi-bin/yabb2/Sources/ModifyMessage.pm, around line 766, a closing curly brace was put in the wrong location. This makes it so that if attachments are disabled, edited posts are not saved/posted. Here is the before/after:
-- BEFORE -- # Create the list of files
$fixfile = join q{,}, @filelist;
${ $thread_arrayref{$threadid} }[$postid] =
qq~$subject|$mname|$memail|$mdate|$musername|$icon|0|$useredit_ip|$message|$ns|$
date|$username|$fixfile\n~;
fopen( FILE, ">$datadir/$threadid.txt" )
or fatal_error( 'cannot_open', "$datadir/$threadid.txt", 1 );
print {FILE} @{ $thread_arrayref{$threadid} }
or croak "$croak{'print'} FILE";
fclose(FILE);
}
if ( $postid == 0 || $staff ) {
-- AFTER --- # Create the list of files
$fixfile = join q{,}, @filelist;
}
${ $thread_arrayref{$threadid} }[$postid] =
qq~$subject|$mname|$memail|$mdate|$musername|$icon|0|$useredit_ip|$message|$ns|$
date|$username|$fixfile\n~;
fopen( FILE, ">$datadir/$threadid.txt" )
or fatal_error( 'cannot_open', "$datadir/$threadid.txt", 1 );
print {FILE} @{ $thread_arrayref{$threadid} }
or croak "$croak{'print'} FILE";
fclose(FILE);
if ( $postid == 0 || $staff ) {
As an aside, I noticed that the lines of interest are the only ones with tabs in that file. Go figure it was a dirty tabber who introduced this terrible bug!