Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #12 - Aug 25th, 2014 at 6:21pm Mark & QuoteQuote Dandello wrote on Aug 25th, 2014 at 6:03pm:I couldn't find where the padding/margin on the span/images was coming from either - that's why the ubbcbutton css has the Code (CSS)margin: 0 -2px Try replacing the "margin: 0 -2px;" css line with "float: left;" ... That worked for me... No more padding/margin. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #11 - Aug 25th, 2014 at 6:12pm Mark & QuoteQuote Dandello wrote on Aug 25th, 2014 at 6:06pm:Monni wrote on Aug 24th, 2014 at 5:48pm: Code $ubbcbak = 'ubbc2.png'; is missing from top of PostBox.pm Actually, it was missing from MyCenter.template. I pretty much rewrote the PostBox.pm last night to cleanup things... I strongly think we should hardcode this filename instead of spreading the variable all around the files... There is some other fixes I need to diff, but currently my tree is pretty much based on assumptions what will become 2.6.2 or beyond, and not 2.6.1... I need to clean it up before I can make a usable diff. GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2266 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #10 - Aug 25th, 2014 at 6:06pm Mark & QuoteQuote Monni wrote on Aug 24th, 2014 at 5:48pm: Code $ubbcbak = 'ubbc2.png'; is missing from top of PostBox.pm Actually, it was missing from MyCenter.template. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Dandello Forum AdministratorYaBB Modder Offline I love YaBB 2.7! Posts: 2266 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #9 - Aug 25th, 2014 at 6:03pm Mark & QuoteQuote I couldn't find where the padding/margin on the span/images was coming from either - that's why the ubbcbutton css has the Code (CSS)margin: 0 -2px Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #8 - Aug 25th, 2014 at 11:05am Mark & QuoteQuote This is how it looks here with 24px per button and 2px left and right margin. « Last Edit: Aug 25th, 2014 at 12:05pm by Monni » GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #7 - Aug 25th, 2014 at 10:22am Mark & QuoteQuote XTC wrote on Aug 25th, 2014 at 10:03am:Hello Ok... what is the best to do now ... ? PostBox.pm or css edit ... or both lg XTC It is obvious one fix doesn't work for all templates... I edited only PostBox.pm to align the css buttons. I haven't figured out yet what is the difference that adds the 1 pixel padding to custom templates on Chrome here, but not default template. I also tested with IE, but it seems it looks even worse as the padding isn't even constant and varies between 0 and 1 pixels... When I did set "float: left" and cleared left and right margins for CSS buttons, the gap disappeared when using Chrome, but as the button spacing was still hardcoded to 24 in sources, the two rows were not same width yet. « Last Edit: Aug 25th, 2014 at 6:07pm by Monni » Reason: Update with more tests GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
XTC Global Moderator Offline YaBB 2.6.0/1/11 Mods Posts: 174 Location: @ustria Joined: Feb 12th, 2014 Gender: Mood: Freaky Zodiac sign: Re: Looking toward 2.6.1 Reply #6 - Aug 25th, 2014 at 10:03am Mark & QuoteQuote Hello Ok... what is the best to do now ... ? PostBox.pm or css edit ... or both lg XTC IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #5 - Aug 25th, 2014 at 7:18am Mark & QuoteQuote Dandello wrote on Aug 24th, 2014 at 11:58pm:When I look at it in Slimbrowser setting the width to *24 makes the lower line wider than the upper one. *23 wide makes them line up again. I think adding a few pixels to $boxlist1_w should widen the entire enclosing box enough to keep the parse box on the same line as the rest of the upper line. (The graphics are 23px wide.) Code (Perl)$ubbc_box_w = $boxlist1_w + $mods_w + 2; I tried to widen it and I had to add 15 pixels before it looked normal. The difference is that in other forums with custom templates there is actually 1 pixel padding between the UBBC buttons... You can adjust .ubbcbutton's margin-left and margin-right (default is -2px for both) to realign the two lines. « Last Edit: Aug 25th, 2014 at 8:31am by Monni » GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2266 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Reply #4 - Aug 24th, 2014 at 11:58pm Mark & QuoteQuote When I look at it in Slimbrowser setting the width to *24 makes the lower line wider than the upper one. *23 wide makes them line up again. I think adding a few pixels to $boxlist1_w should widen the entire enclosing box enough to keep the parse box on the same line as the rest of the upper line. (The graphics are 23px wide.) Code (Perl)$ubbc_box_w = $boxlist1_w + $mods_w + 2; Perfection is not possible. Excellence, however, is excellent. WWW IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #3 - Aug 24th, 2014 at 9:43pm Mark & QuoteQuote XTC wrote on Aug 24th, 2014 at 8:05pm:@Monni Code (Perl) $boxlist_w = $w * 23; ....is present twice (sub ubbc_boxlist & sub ubbc_modlist) lg XTC Thanks, updated the patch in previous post... GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
XTC Global Moderator Offline YaBB 2.6.0/1/11 Mods Posts: 174 Location: @ustria Joined: Feb 12th, 2014 Gender: Mood: Freaky Zodiac sign: Re: Looking toward 2.6.1 Reply #2 - Aug 24th, 2014 at 8:05pm Mark & QuoteQuote @Monni Code (Perl) $boxlist_w = $w * 23; ....is present twice (sub ubbc_boxlist & sub ubbc_modlist) lg XTC IP Logged
Monni Language Offline Min izāmō Posts: 413 Location: Kaarina, Finland Joined: Jul 16th, 2014 Gender: Mood: Frustrated Zodiac sign: Re: Looking toward 2.6.1 Reply #1 - Aug 24th, 2014 at 7:41pm Mark & QuoteQuote Revising my previous patch... Code --- C:/Users/Mika/AppData/Local/Temp/PostBox.pm-revBASE.svn001.tmp.pm Fri Aug 22 16:41:00 2014 +++ C:/build/yabb/trunk/cgi-bin/yabb2/Sources/PostBox.pm Mon Aug 25 00:41:31 2014 @@ -20,6 +20,8 @@ $postboxpmver = 'YaBB 2.6.0 $Revision: 1545 $'; if ( defined $actions && $action eq 'detailedversion' ) { return 1; } get_micon(); +$ubbcbak = 'ubbc2.png'; + #InstantMessage.pm and Post.pl use the same code for the posting box - why have two copies? # sub postbox { @@ -912,7 +914,7 @@ $boxlist .= qq~<span class="ubbcbutton" style="background-image: url($imagesdir/UBBC/$ubbcbak);"><img src='$imagesdir/UBBC/$img' onclick='$click;' $hand alt='$alt' title='$alt' /></span>\n~; $w++ } - $boxlist_w = $w * 23; + $boxlist_w = $w * 24; return ($boxlist, $boxlist_w); } @@ -933,7 +935,7 @@ else { $mod_w = 1 + int $w/2; } - $boxlist_w = $mod_w * 23; + $boxlist_w = $mod_w * 24; return ($boxlist, $boxlist_w); } « Last Edit: Aug 24th, 2014 at 9:42pm by Monni » Reason: Revise patch GTalk Skype/VoIP Facebook Twitter YouTube ICQ IP Logged
Dandello Forum Administrator Offline I love YaBB 2.7! Posts: 2266 Location: The Land of YaBB Joined: Feb 12th, 2014 Gender: Mood: Annoyed Zodiac sign: Re: Looking toward 2.6.1 Aug 24th, 2014 at 7:24pm Mark & QuoteQuote XTC wrote on Aug 24th, 2014 at 7:17pm:Slimbrowser! In PostBox.pm find Code (Perl) $ubbc_box_w = $boxlist1_w + $mods_w; That's the section that sets the px width of the UBBC box overall. See if adding 1 or 2 to it helps. Perfection is not possible. Excellence, however, is excellent. WWW IP Logged